search

bibanon / tubeup

Use yt-dlp to download video/metadata and upload to the Internet Archive.
https://pypi.python.org/pypi/tubeup/
GNU General Public License v3.0
424 stars 71 forks source link

Remove unneeded dependency #305

Closed mrpapersonic closed 1 year ago

mrpapersonic commented 1 year ago

We don't use urllib3 at all, so this shouldn't break anything.

brandongalbraith commented 1 year ago

@mrpapersonic let me double check, I think this might have been an internetarchive lib dependency.

brandongalbraith commented 1 year ago

@mrpapersonic https://github.com/bibanon/tubeup/pull/267#issuecomment-1336225668 https://github.com/jjjake/internetarchive/blob/ee8955065e8ffcbdc040a9d88721bb0364cfd28f/pex-requirements.txt#L8

brandongalbraith commented 1 year ago

Whatever issue was previously present due to the urllib3 dep in https://github.com/jjjake/internetarchive seems to have abated based on tests passing in this PR.

@mrpapersonic Can you confirm via testing with this branch that with this dependency removed nothing breaks?

mrpapersonic commented 1 year ago

@mrpapersonic Can you confirm via testing with this branch that with this dependency removed nothing breaks?

I just tested uploading with this branch, and it looks like it works: https://archive.org/details/youtube-hoXJ0ki94fI

brandongalbraith commented 1 year ago

@mrpapersonic Thank you!

vxbinaca commented 1 year ago

I'll cut a new version in a sec thanks guys

brandongalbraith commented 1 year ago

Thanks @vxbinaca!