search

bibanon / tubeup

Use yt-dlp to download video/metadata and upload to the Internet Archive.
https://pypi.python.org/pypi/tubeup/
GNU General Public License v3.0
424 stars 71 forks source link

pyproject.toml: lock internetarchive dep to <5.0.0 #337

Closed mrpapersonic closed 2 weeks ago

mrpapersonic commented 2 weeks ago

Closes #336, the code ought to be updated to the new major API though.

vxbinaca commented 2 weeks ago

4.1.0 still works with post-hack IA but yeah we should force 5.0.0 at least.

vxbinaca commented 2 weeks ago

Uh @mrpapersonic we should be dep locking to 4.1.0 since we haven't updated Tubeup to use the newly formatted commands.

vxbinaca commented 2 weeks ago

so my understanding is I should be able to swap out docopt for argparse and be okay?

mrpapersonic commented 2 weeks ago

so my understanding is I should be able to swap out docopt for argparse and be okay?

The issue looks to be an issue in the internetarchive library itself. When sending a custom uploader metadata, it tacks on the regular IA python library metadata on the end as a list, which trips up its own header validation :p

Best thing to do for now IMO is cap the version as "less than 5.0.0" (as in, not 5.0.0 and any non-API-breaking changes to the 4.0.0 releases)

We also can't get rid of docopt for now because we use it for our own argument parsing, unrelated to internetarchive. It would be nice if we could replace it with something more up-to-date though.

vxbinaca commented 2 weeks ago

right I'm pushing a bandaid fix that locks the dep at 4.1.0 or the latest before 5.0.0

vxbinaca commented 2 weeks ago

so that didn't work but what does work is special install instructions, injecting old IA library into tubeup venv.