bibendi / activerecord-postgres_enum

Integrate PostgreSQL's enum data type into ActiveRecord's schema and migrations.

MIT License

361 stars 24 forks source link

Existance checks for create and drop enums and cascade: true for drop_enum #27

Closed hosembafer closed 4 years ago

hosembafer commented 4 years ago

24 What's inside

[x] add if_not_exists: true option to create_enum
[x] add if_exists: true option to drop_enum
[x] add cascade: true to drop_enum

Checklist:

[x] I have added tests

hosembafer commented 4 years ago

Also, would be nice to document if_not_exists, if_exists, cascade or it's enough to rely on Github's hover tooltip annotation?

bibendi commented 4 years ago

Wow! Brilliant! I don't know what Github's hover tooltip annotation is, but any documentation is always desirable. So, as you wish :)

hosembafer commented 4 years ago

When hovering on code snippet more than 1-2 sec, tooltip appearing. I think would be better to issue a new ticket and improve API documentation overall if you think so. Yep, so this PR can be merged regardless of the documentation.

github-tooltip-annotation

bibendi commented 4 years ago

Got it!