Refactor type schema to make flavorTypes and flavors explicit

mvahowe commented 4 years ago

This PR is part 2 of refactoring the schema structure before working on the detail.

The most significant changes are in type.schema.json.

I've moved several hundred lines of JSON conditionals related to canons into their own file.
I've moved the flavorType/flavor logic into cascading oneOfs. I'm happy to revisit this later for reasons of efficiency (supported by comparative benchmarks) but, for now, I think that a declarative style is much easier to reason about.
I believe that I've implemented the flavorType constraints, although this is currently untested due to lack of test documents.

Some time soon I'd like to consider moving all the scope-type fields under one object. I didn't do it in this PR in the interests of transparency.

The files should be indented correctly, and should end with a newline.

After this PR I think it should be feasible to do multiple PRs in parallel.

mvahowe commented 4 years ago

The test document was invalid, and CI checks were failing silently. This has been fixed by @rdb and me.

mvahowe commented 4 years ago

@rdb Thanks. I still fantasize about tweaking the format into RelaxNG :-)

bible-technology / scripture-burrito