Create Test Data for textTranslation_derived

bible-technology / scripture-burrito

Scripture Burrito Schema & Docs 🌯

http://docs.burrito.bible/

MIT License

21 stars 13 forks source link

Create Test Data for textTranslation_derived #194

Closed jag3773 closed 3 years ago

jag3773 commented 4 years ago

Definition of Done

[x] Repository created at https://github.com/bible-technology/sb_textTranslation_derived
[x] Automated testing with passing json-schema validation against metadata.json
[x] All ingredients present and valid according to type and hash

jtauber commented 3 years ago

The textTranslation_derived metadata from the doc examples artifacts has ingredients like release/text/USX_1/OTINT.usx. Are those files something I could include in the test repo or should I completely fabricate new ingredients for this test repo?

Also, I can easily verify by hash but how much other validation should I do of ingredient file format?

jtauber commented 3 years ago

Regarding

Also, I can easily verify by hash but how much other validation should I do of ingredient file format?

I notice that existing test repos don't have any automated testing even of hashing. Is that something we want to add to a validation suite?

jag3773 commented 3 years ago

Yes, the current spec is very minimal on ingredient specification and/or validation. In general, we want to be more particular about ingredients (you know, Non-GMO, Organic, Gluten-Free, etc.).

jtauber commented 3 years ago

removed the recipe spec requirement

jag3773 commented 3 years ago

You can use a subset of https://github.com/bible-technology/sb_textTranslation/tree/master/ingredients .

jtauber commented 3 years ago

Gospel subset moved over, realistic updates to metadata and size/checksums now work out.