bibledit / cloud

Source code for Bibledit core library and Cloud binary
GNU General Public License v3.0
13 stars 3 forks source link

Non-clickable link in Android app #321

Closed warpok closed 5 years ago

warpok commented 5 years ago

Screenshot 2019-09-10 at 9 12 56 PM This is on the Chromebook running the Android app.

warpok commented 5 years ago

The Add a comment link was totally unclickable.

teusbenschop commented 5 years ago

What kind of device was the link unclickable?

warpok commented 5 years ago

I just experienced this non-clickable problem again just now. I am using my Asus Chromebook Flip this morning. And Bibledit is installed as an Android app. I was able to use the Edit comment link on the last note (since my note was the last one) instead of adding a comment. The Edit link was not highlighting normally, but just like on my tablet, by very careful positioning of the mouse I was able to click it. But there was no way to get the lower Add Comment link to activate.

teusbenschop commented 5 years ago

There's something going on that is making the links hard to click. The links themselves are just normal standard links. There's nothing special to them. Links on the Bibledit demo at http://bibledit.org:8080/notes/index click well, no problem here. There's definitely something going on there.

warpok commented 5 years ago

I went to the address that you stated in your reply. First of all, the problem never seems to show up in the dedicated Translate

Notes screen, but only in Workspaces. And the page I had contained no notes. This only happens when the Add Comment link sinks to the very bottom of a workspace pane. And I don't think that it ever happens in the Cloud version in a browser (like I get from your link). This only is happening in the Android app (whether on Chromebook or Linux). It might happen elsewhere, but I am not sure.

Phil

=============== Phil Fields

USA: 479-524-7005

Indonesia and Whatsapp: +6285 770 333 734

303 Ryan Ct., Siloam Springs, AR 72761

albata.info dailybiblereading.info Firman Allah adalah Kunci Kehidupan

Pada tanggal Rab, 11 Sep 2019 pukul 08.50 Teus Benschop < notifications@github.com> menulis:

There's something going on that is making the links hard to click. The links themselves are just normal standard links. There's nothing special to them. Links on the Bibledit demo at http://bibledit.org:8080/notes/index click well, no problem here. There's definitely something going on there.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bibledit/cloud/issues/321?email_source=notifications&email_token=ABDSIJN77HE6DFTBIU5RRELQJDZSXA5CNFSM4IVONNT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6ORVHY#issuecomment-530389663, or mute the thread https://github.com/notifications/unsubscribe-auth/ABDSIJLXAH762VBNGNG5RTDQJDZSXANCNFSM4IVONNTQ .

warpok commented 5 years ago

The problem happens when the Android client is logged onto the demo server! by the way, I was disturbing that the demo was still reading my Indonesian data. Screenshot_20190911-150016_Bibledit Screenshot_20190911-145938_Bibledit Screenshot_20190911-145921_Bibledit Screenshot_20190911-150211_Bibledit

warpok commented 5 years ago

The last screenshot shows the link at the bottom, and that link was not clickable, even with my stylus. This was on the Samsung Tablet.

warpok commented 5 years ago

After logging on with the app, look what appeared in my email: 20190911_151108

teusbenschop commented 5 years ago

With regard to your Indonesian data, I understand that seeing this on the demo server is disturbing. Anyone connects to that server with their clients, and all kinds of bibles are put on there, without me checking on that. Somehow somebody with your Indonesian data once connected to the demo server from their client, and then the client started uploading whatever was on that client. The system is made sticky a bit, so that rather than deleting Bibles, it has a tendency to add. The purpose of this is that never Bible data gets lost. Some Bibles present years and years of work. So that requires the care.

With regard to the non-clickable links: I tried it just now again with the newest Bibledit client app from the Google Play Store. It's an emulated Android 8 device. Links to add comments to notes click well in the following situations:

  1. Separate notes.
  2. Notes in workspaces.
  3. Notes in workspaces where the link is a the bottom of the screen.

I am soo puzzled by this, by what you are seeing on your Samsung tablet and Chrome OS app.

teusbenschop commented 5 years ago

If you are moving a Bibledit client from one server to the next server, some undefined things happen, while trying to preserve all Bible data on the devices. That would be related to what you are seeing in your emails.

teusbenschop commented 5 years ago

Hey, I am now seeing the behaviour of the non-clickable note too on my own Nexus device!

teusbenschop commented 5 years ago

I think the position where one cannot click the link is where normally the zoom-controls are located.

ZoomControls-In-Android

Most likely the zoom-controls kind of cover the link. This would result in a situation where one taps on where the link is, that one really is thouht by Android to be tapping the zoom-controls.

I think this is causing it.

So a possible solution would be to disable the zoom controls.

warpok commented 5 years ago

Great idea. This is happening even when the zoom control is not showing. But Android may not be relingquishing the zoom control location after it disappears. Disabling that is a good thing to try.

warpok commented 5 years ago

Ha! I’m glad you have seen the problem on your Nexus!

teusbenschop commented 5 years ago

The code of the Android app was updated as follows:

webview.getSettings().setBuiltInZoomControls (false);

Then an update was released to the Beta channel on the Google Play Store.

This Beta app was tested on the Nexus 6. But the affected links remained unclickable.

The conclusion is that this code updated that not resolve the problem.

I am leaving the code update in because it's good to get rid of the zoom controls that at times get in the way anyway.

So although the code update didn't fix the problem, it's still good to have it in.

teusbenschop commented 5 years ago

The Android WebView API at https://developer.android.com/reference/android/webkit/WebSettings.html#setBuiltInZoomControls(boolean) confirms that the built-in zoom controls cover content on the WebView:

public abstract void setBuiltInZoomControls (boolean enabled)

Sets whether the WebView should use its built-in zoom mechanisms. The built-in zoom mechanisms comprise on-screen zoom controls, which are displayed over the WebView's content, and the use of a pinch gesture to control zooming. Whether or not these on-screen controls are displayed can be set with setDisplayZoomControls(boolean). The default is false.

The built-in mechanisms are the only currently supported zoom mechanisms, so it is recommended that this setting is always enabled.

warpok commented 5 years ago

I forgot to point out: The zoom mechanism only appears at the lower right. In a 4-pane (2 row) workplace with the upper right pane as the Notes, the Add Comment link will never be at the bottom right of the screen, but if that link is near the dividing line, it will be unclickable (or stubborn to click) on my tablet.

teusbenschop commented 5 years ago

Thank you for pointing that out.

Then the conclusion is that the issue of the unclickable link is not related to the built-in zoom controls.

That conclusion is confirmed by the following code update that also didn't fix the issue:

    webview.getSettings().setBuiltInZoomControls (false);
    webview.getSettings().setSupportZoom (false);
    webview.getSettings().setDisplayZoomControls (false);

Also changing

<meta name="viewport" content="width=device-width, initial-scale=1.0">

to

<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no">

didn't make any difference at all.

So: Ahead to look for another solution then.

teusbenschop commented 5 years ago

The next thing to try, that actually should work, is to add lots of space below the link. Adding say

<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>

and so on, in html, should add this space below the link.

Then this extra space will shift the link up. Then it becomes clickable.

teusbenschop commented 5 years ago

A new version was released. Version 5.0.794. That has more space, quite some more, below the link that could not be clicked. This extra space allows the link to be shifted upwards. That move the link into an area that appears to be clickable.