bibledit / cloud

Source code for Bibledit core library and Cloud binary
GNU General Public License v3.0
13 stars 3 forks source link

Reload text error message #406

Closed warpok closed 4 years ago

warpok commented 4 years ago

In another thread I believe that you mentioned the issue of having a popup message should be in a separate thread. So I have started this one.

Screenshot_20200622-145743_Chrome

warpok commented 4 years ago

Today it is clear that I am the only one working in this chapter. First I was working with two tablets, having an edit window on both Bibledit desktops. That caused the popup message to come up repeatedly. So I made a separate workspace that has two views of the resources for the second tablet, and just had one editing window on my one tablet. I still get the popup happening in spite of the fact that I am the only one editing in this chapter. All of my team in Indonesia would be asleep. It is possible another team member would be working in another chapter of 2nd Samuel in the USA.

warpok commented 4 years ago

During the time when I was working alone in this chapter, but with two editors open on two tablets, I got this failure to merge email:

Base text

\v 1 Suatu hari, TUHAN murka kepada umat Israel. Maka untuk menimpakan hukuman atas bangsa itu, Dia menimbulkan dorongan dalam hati Daud\f \fr 24:1 \fk menimbulkan .. \ft seperti ini, “Hitunglah jumlah orang Israel dan Yehuda.” \p

Changed text

\v 1 Suatu hari, TUHAN murka kepada umat Israel. Maka untuk menimpakan hukuman atas bangsa itu, Dia menimbulkan dorongan dalam hati Daud\f \fr 24:1 \fk menimbulkan .. \ft Di cerita yang sama di seperti ini, “Hitunglah jumlah orang Israel dan Yehuda.” \p

Existing text

\v 1 Suatu hari, TUHAN murka kepada umat Israel. Maka untuk menimpakan hukuman atas bangsa itu, Dia menimbulkan dorongan dalam hati Daud\f \fr 24:1 \fk menimbulkan .. \ft seperti ini, “Hitunglah jumlah orang Israel dan Yehuda.” \p

The text that was actually saved to the chapter

\v 1 Suatu hari, TUHAN murka kepada umat Israel. Maka untuk menimpakan hukuman atas bangsa itu, Dia menimbulkan dorongan dalam hati Daud\f \fr 24:1 \fk menimbulkan .. \ft seperti ini, “Hitunglah jumlah orang Israel dan Yehuda.” \p

warpok commented 4 years ago

But when I am the only one working in a chapter, it doesn't make sense why Bibledit would have to show the error message. Even if I have two editing panes open, with only one of them being used for editing, it seems to be a bug in the program when I experience data loss in the editing of a footnote. Once again, editing footnotes using USFM mode often seems to bring about data loss.

warpok commented 4 years ago

These false error messages are coming up on every verse I edit. I can’t capture them with a screenshot. Please revert back to the way the program was before. This is going to drive our team batty, unless it doesn’t happen when using the cloud program.

warpok commented 4 years ago

Screenshot_20200623-064130_Chrome

warpok commented 4 years ago

This is the first time I have been able to screenshot the updated Text error message. I was just trying out the direct move Ctrl-G shortcut. It works fantastically! But the Updated text should not have shown up, because I just clicked away one of these in 2Samuel, then did a Ctrl-G move to Genesis 4:1, and the error showed up in Genesis also. And this was using the Cloud Bibledit! It doesn’t make sense for the cloud program to have these mssages showing up!

warpok commented 4 years ago

I have just viewed the video you sent in thread 396. I am sure that the updated text reload button will work if there are two people editing in the same chapter. But now it is happening when only one person (me) is editing and only on one Android tablet.

After my complaint that the error message came up in the Cloud, I worked the rest of the morning without seeing it in the Cloud. But this afternoon working using the Android client, the Updated text window appeared several times. But no one else was working in the same book.

warpok commented 4 years ago

In the cloud, frequently moving to a new chapter/verse causes the error message. The translation coordinator in Indonesia is seeing this also. He mentioned it as annoying.

warpok commented 4 years ago

Because of so many annoying ‘Updated text’ messages coming up in the client application, I have shifted to using Bibledit cloud, as I think my team has done as well.

I don’t get why I would get the ‘updated text’ message at the moment when I shift to a new chapter in the cloud app.

teusbenschop commented 4 years ago

I am trying to reproduce those and see what's going on that is causing these messages to come up.

teusbenschop commented 4 years ago

Just now after trying 50+ of verse and chapter switches, I had the "reload message" once on bibledit.org:2016.

teusbenschop commented 4 years ago

It seems there is a timing issue that causes the "reload text" alert box to pop up.

May you assist a bit with this since you are seeing the alert relatively often.

After you have done the last edit in one verse, before switching to the next verse, in the verse editor, could you wait at least two seconds? In those two seconds the system should settle down and no timing issues should occur, and no "reload text" should pop up anymore.

Could you assist with this by trying it out, whether the "reload text" alerts no longer come up?

teusbenschop commented 4 years ago

The following was fixed in the Bible verse editor:

Upon saving text, it displayed an alert about text that was reloaded. If going to another verse, it displayed an alert about text that was reloaded. All of these alerts were in error, because no text was reloaded. It has been fixed in all Cloud instances at bibledit.org.

Which of the clients are to be fixed also?

warpok commented 4 years ago

So sorry I didn't see your last two questions in a timely way. I take it that you found the problem! Yay! I have seen the message come up once today in the cloud, just when I moved to the chapter I am now working on. For sure, please fix the Android client. But it looks like you decided to do that anyway, since you released to 'all ports'. Thanks so much!

warpok commented 4 years ago

Working using the cloud today, I am still getting the Redoad messages every time I go to a new chapter. This is using the Samsung tablet and the Chrome browser.

teusbenschop commented 4 years ago

Thanks for trying that out.

Let me hold on to updating all clients, and fix this error first.

I had checked that it no longer showed the "Reload" alert while doing the normal editing within the chapter. And had not tried what would happen when going to another chapter.

Your tests assist with this. So I am going to look into this also.

Thanks for contributing to Bibledit!

teusbenschop commented 4 years ago

Since the new release of the Bibledit 4 Android was already in the loop, I could easily release it. It is version 5.0.900. It has the fix for the "Reload" message while editing within a chapter. When moving to another chapter, the fix for that is not yet in 5.0.900.

teusbenschop commented 4 years ago

I am putting out a new Bibledit client for Ubuntu too, because the good things contained in the current fix are so good that they need to get out to the people now.

So expect an Bibledit for Ubuntu update soon :)

And while there's time I can move on to working on the alert not popping up on chapter switch.

warpok commented 4 years ago

Thank you SO Much! I confess I didn't quite understand exactly when I would see the change to 5.0.900 in the cloud, since my cloud version was still not up to that version yesterday.

I have discovered a nice 'feature' when working with the Cloud. I can have my other tablet also in the cloud and positioned to show two different views of the resources. When I move the cloud version I am using for editing, the other one moves too (with a bit of a lag), so that it makes it like having two monitors.

warpok commented 4 years ago

The Ubuntu version has now updated. The Android app has also updated. Thanks!

teusbenschop commented 4 years ago

Thank you SO Much! I confess I didn't quite understand exactly when I would see the change to 5.0.900 in the cloud, since my cloud version was still not up to that version yesterday.

I was perhaps unclear about it, but the version number in the Cloud would be 5.0.899 that has the fix. That's the same fix as will be in the Android / Ubuntu client 5.0.900.

teusbenschop commented 4 years ago

I have discovered a nice 'feature' when working with the Cloud. I can have my other tablet also in the cloud and positioned to show two different views of the resources. When I move the cloud version I am using for editing, the other one moves too (with a bit of a lag), so that it makes it like having two monitors.

Yes, that's a great feature indeed.

Which means you may have "multiple monitors" if so desired :)

warpok commented 4 years ago

Today I was working in the new client, the 50900 one. I was adding a footnote in 5:17, when the error happened. Screenshot_20200705-145132_Bibledit

warpok commented 4 years ago

I think, but am not sure, that there was the Reload error message. I was struggling to make a screenshot, I think, when it disappeared. The cursor moved from v. 17 to 18. The Client program may have skipped inside 18 about the same amount of characters that it failed to save in 17. Email received:

warpok commented 4 years ago

Failed to merge: The existing text was kept While merging the text, something unusual was detected.

Base text

\v 17 Pada waktu bangsa Filistin mendengar bahwa Daud sudah diurapi dan diangkat menjadi raja atas Israel, mereka mengumpulkan seluruh pasukan untuk mencari dan menangkap Daud. Tetapi Daud mendengar hal itu, lalu [turun//pergi] dengan pasukannya ke tempat perlindungan di padang balantara.\f \fr 5:17 \fk tempat perlindungan .. \ft Dalam bahasa Ibrani di ayat ini pasukan Filistin 'naik' untuk 'mencari' atau menyerang Daud, sedangkan Daud 'turun' ke tempat perlindungan. Biasanya dalam kebudayaan Israel, kalau pergi ke ibukota Yerusalem, itu selalu disebut 'naik', walaupun bukit Sion tidak terlalu tinggi. Pergi dengan lawan arah biasanya disebut 'turun'. Karena itu, dipikirkan bahwa tempat perlindungan di mana Daud memimpin \f*

Changed text

\v 17 Pada waktu bangsa Filistin mendengar bahwa Daud sudah diurapi dan diangkat menjadi raja atas Israel, mereka mengumpulkan seluruh pasukan untuk mencari dan menangkap Daud. Tetapi Daud mendengar hal itu, lalu [turun//pergi] dengan pasukannya ke tempat perlindungan di padang balantara.\f \fr 5:17 \fk tempat perlindungan .. \ft Dalam bahasa Ibrani di ayat ini pasukan Filistin 'naik' untuk 'mencari' atau menyerang Daud, sedangkan Daud 'turun' ke tempat perlindungan. Biasanya dalam kebudayaan Israel, kalau pergi ke ibukota Yerusalem, itu selalu disebut 'naik', walaupun bukit Sion tidak terlalu tinggi. Pergi dengan lawan arah biasanya disebut 'turun'. Karena itu, dipikirkan bahwa tempat perlindungan di mana Daud memimpin pasukannya adalah tempat \f*

Existing text

\v 17 Pada waktu bangsa Filistin mendengar bahwa Daud sudah diurapi dan diangkat menjadi raja atas Israel, mereka mengumpulkan seluruh pasukan untuk mencari dan menangkap Daud. Tetapi Daud mendengar hal itu, lalu [turun//pergi] dengan pasukannya ke tempat perlindungan di padang balantara.\f \fr 5:17 \fk tempat perlindungan .. \ft Dalam bahasa Ibrani di ayat ini pasukan Filistin 'naik' untuk 'mencari' atau menyerang Daud, sedangkan Daud 'turun' ke tempat perlindungan. Biasanya dalam kebudayaan Israel, kalau pergi ke ibukota Yerusalem, itu selalu disebut 'naik', walaupun bukit Sion tidak terlalu tinggi. Pergi dengan lawan arah biasanya disebut 'turun'. Karena itu, dipikirkan bahwa tempat perlindungan di mana Daud memimpin \f*

The text that was actually saved to the chapter

\v 17 Pada waktu bangsa Filistin mendengar bahwa Daud sudah diurapi dan diangkat menjadi raja atas Israel, mereka mengumpulkan seluruh pasukan untuk mencari dan menangkap Daud. Tetapi Daud mendengar hal itu, lalu [turun//pergi] dengan pasukannya ke tempat perlindungan di padang balantara.\f \fr 5:17 \fk tempat perlindungan .. \ft Dalam bahasa Ibrani di ayat ini pasukan Filistin 'naik' untuk 'mencari' atau menyerang Daud, sedangkan Daud 'turun' ke tempat perlindungan. Biasanya dalam kebudayaan Israel, kalau pergi ke ibukota Yerusalem, itu selalu disebut 'naik', walaupun bukit Sion tidak terlalu tinggi. Pergi dengan lawan arah biasanya disebut 'turun'. Karena itu, dipikirkan bahwa tempat perlindungan di mana Daud memimpin \f*

teusbenschop commented 4 years ago

The email that was received now has been clarified in the newest Cloud version that is going to be installed in hours. That is going to be version Bibledit 5.0.901.

I have tried to reproduce the exact edit that caused the email, the very exact editing, but could not reproduce it.

So the current solution is as above: To make the email clearer, a better layout, so it becomes possible to instantly see what part of the text you changed, and what the server made it through a merge operation.

I am open to more cases of the same, in the hope that eventually we can improve the situation more and more.

Please open new issues for each case.

warpok commented 4 years ago

Excellent! Thanks so much. I’ll be looking out for emails. I have been getting very few merge error messages this week. Phil

Phil Fields USA: 479-524-7005 Indonesia/WA: +6285770333734 P.O. Box 701, Siloam Springs, AR 72761

http://albata.info http://dailybiblereading.info

One King to rule them all, One Son to find them, One blood to cleanse them all, And from the dark unbind them.

On Sat, Jul 11, 2020, 8:33 AM Teus Benschop notifications@github.com wrote:

The email that was received now has been clarified in the newest Cloud version that is going to be installed in hours. That is going to be version Bibledit 5.0.901.

I have tried to reproduce the exact edit that caused the email, the very exact editing, but could not reproduce it.

So the current solution is as above: To make the email clearer, a better layout, so it becomes possible to instantly see what part of the text you changed, and what the server made it through a merge operation.

I am open to more cases of the same, in the hope that eventually we can improve the situation more and more.

Please open new issues for each case.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bibledit/cloud/issues/406#issuecomment-657063111, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDSIJM5YIDDRGFUX6WIUDDR3BS37ANCNFSM4OE7U4HQ .