search

bibledit / cloud

Source code for Bibledit core library and Cloud binary
GNU General Public License v3.0
13 stars 3 forks source link

Chapter / Verse picker in client and sometimes in cloud not working for Red Blue theme #655

Closed warpok closed 3 years ago

warpok commented 3 years ago

Aranggi, the chapter/verse picker is not working properly for the Red Blue theme, both light and dark. This is especially in the client and for some browsers at least, also in the cloud.

warpok commented 3 years ago

Screenshot_20210715-101158_Bibledit

aranggitoar commented 3 years ago

Hello @warpok! Thank you for the report.

But I couldn't seem to reproduce the bug on cloud's port for TSI. Not in Chrome, Firefox, neither in Safari.

Can you tell me what machine are you using to run the client?

warpok commented 3 years ago

That is Android and Ubuntu/Linuxmint.

=============== Phil Fields USA: 479-524-7005 Indonesia and Whatsapp: +6285 770 333 734

albata.info dailybiblereading.info

      Firman Allah adalah Kunci Kehidupan

===============

On Wed, Jul 21, 2021, 11:31 AM Aranggi Josef Toar @.***> wrote:

Hello @warpok https://github.com/warpok! Thank you for the report.

But I couldn't seem to reproduce the bug on cloud's port for TSI. Not in Chrome, Firefox, neither in Safari.

Can you tell me what machine are you using to run the client?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bibledit/cloud/issues/655#issuecomment-884325943, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDSIJKBI7N3D3E3FRAVFHDTY3Y4VANCNFSM5ANYHOWA .

aranggitoar commented 3 years ago

Hello @warpok, so this bug was fixed on this commit. Exactly at line 512 to 514 for the css/stylesheet.css file. I've tested that removing the update exactly for those lines would yield this bug. So for the Cloud version there shouldn't be any problem. Can you check it again for me if the bug really occurs on Cloud? Also on what browser does the bug occur?

But for the Android and Ubuntu/Linux Mint client, the bug occurs because the last update done to Google Play and Linux's package repository was before the commit I've linked above, before the fix for this bug.

So brother @teusbenschop have to help us on that. :-) I've refreshed the source for Android but haven't updated the version.

Edit: Brother @teusbenschop can you give me references that explains uploading and updating packages that can be installed through the apt API? I'm learning the scripts you made to update the packages for Linux in bibledit/linux and bibledit/packaging repo. :-)

teusbenschop commented 3 years ago

Will do so, but perhaps it's an idea I can wait till you confirm that the Ubuntu beta edition is okay, sounds good?

aranggitoar commented 3 years ago

Yes, that sounds great!

And @warpok, I've linked a screen recording for this issue on the other thread, #647. Kindly refer to it there. :-)

warpok commented 3 years ago

This is still happening in the new version Android client.

Screenshot_20210725-150316_Bibledit

warpok commented 3 years ago

Thanks, Aranggi!