bibledit / cloud

Source code for Bibledit core library and Cloud binary
GNU General Public License v3.0
13 stars 3 forks source link

Move gradually to std::filesystem #952

Open teusbenschop opened 2 months ago

teusbenschop commented 2 months ago

It is now time to use the newer filesystem calls from the std::filesystem library.

To keep testing whether it keeps working after the move.

teusbenschop commented 2 months ago

When enabling std::filesystem on Android, several devices had native crashes. This are crashes in C++.

Device(s) with issues Google Pixel 6 (oriole) - Android 12 Google Pixel 5 64-bit only (redfin_64) - Android 13 Google Pixel 7 (panther) - Android 13 Motorola Motorola G20 (java) - Android 11 Generic Small Desktop (x86) (SmallDesktop.x86) - Android 12L

Exceptions Native crash of org.bibledit.android Native crash of org.bibledit.android Native crash of org.bibledit.android Native crash of org.bibledit.android Native crash of org.bibledit.android Native crash of org.bibledit.android

teusbenschop commented 2 months ago

For Ubuntu 22.04 see this issue: https://github.com/bibledit/cloud/issues/960 That is why the std::filesystem is disabled for all of Cloud and Linux client, just to be sure.