search

biblepay / biblepay

BiblePay - Helping Orphans Globally
https://www.biblepay.org
MIT License
27 stars 15 forks source link

One Click Mining Configuration corrupts biblepay.conf #21

Closed fogoat closed 4 years ago

fogoat commented 5 years ago

This in reference to old issue about corrupt biblepay.conf.

Using 1.4.4.9 on macOS, I erased biblepay.conf and started BiblePay-QT

Went into Tools, select One Click Mining Configuration

image

Then Click OK on warning

image

Looked at created file using hex fiend for macOS:

image

biblepay commented 5 years ago

Good find, what Mac OS is this exactly?

I think we need a code change with an additional moniker - we currently only have linux/windows monikers - but we can add one for OSX.

So whats happening above is we are treating your Mac like "linux" - emitting each line with a "0A" between each line, instead of the specific MAC lfcr. I believe mac needs lfcr, windows crlf, and linux lf. We current have : crlf OR LF in the code only (we need 3 and we have 2).

fogoat commented 5 years ago

Sorry, I have to re-open issue because after testing on Windows 10, look at the biblepay.conf from One Click Miner Configuration. The line ending is 0x0D 0x0D 0x0A

191002-21

biblepay commented 4 years ago

So far, my tests have been successful on windows and linux. We may need to pull MIP in on this because I dont have a mac.

MIP, can we test this in the testnet branch?

I have an easy test case. The latest wallet 1.4.6.7 stores the PursePrivKey in the biblepay.conf file using this same function; can you please set up your purse priv key and see if your external wallet sends a tx without an error?

fogoat commented 4 years ago

@biblepay @MIPPL On testnet every time an external purse creates a private key, the line ending is encoded as macOS according to Notepad++

biblepay commented 4 years ago

MIP tested it and it works on Mac, so I have no evidence its broken anywhere.

No such line ending as a mac line ending.
Mac moved to LF.