search

biblepay / biblepay_legacy

BiblePay
MIT License
35 stars 34 forks source link

wallet 1.1.3.6 #28

Closed bovcan closed 6 years ago

bovcan commented 6 years ago

in 1.1.3.6 Recent Transactions are not updated on the main page in the wallet.

thesnat21 commented 6 years ago

researching.

OrbisPictus commented 6 years ago

I havent problem with "not updating". There is just some type of filter and there are visible only "direct" (received or sent) transactions. There are missing tx with PODC payment. It is not that same? Is it possible to bring PODC payout back to title screen?

thesnat21 commented 6 years ago

I think that's what they meant. PODC payments are not showing in the "recent transactions" on the main page.

I found the issue, will get a fix for it shortly.

thesnat21 commented 6 years ago

Ok, found it ... have a solution Quick question: Do you want to see PODC updates in the recent as well?

OrbisPictus commented 6 years ago

PODC update is not interesting for me... It's enough to have it in tx detail tab. It would be like a spam :) That's my opinion. Interesting for me: sent, received, mined, MN reward.

thesnat21 commented 6 years ago

fair enough. https://github.com/biblepay/biblepay/pull/29 pull request submitted.

bovcan commented 6 years ago

...ok. I found it later in Transaction tab, because at first I was thinking I didnt get podc payment. I didn't saw this was removed in "changelog", so I thought it is a bug or smth. It's fine as it is now..

thesnat21 commented 6 years ago

I would still consider it a bug, items being filtered from the main list, and podc payments missing from "most common" People are used to seeing PODC payments on the main screen, it will be fixed in the next release

bovcan commented 6 years ago

good point.

biblepay commented 6 years ago

Thanks guys, looking at the solution Snat gave.

biblepay commented 6 years ago

Merging, please test this fix in 1.1.4.2.

biblepay commented 6 years ago

Looks like it fixed it, great work!