Configuration not read biblepay.conf is Mac file format (CR) on Windows QT

[fogoat]

@thossoma on BiblePay Discord experienced configuration issues on his Windows QT wallet because biblepay.conf was a Macintosh file-format (CR).

https://stackoverflow.com/questions/1552749/difference-between-cr-lf-lf-and-cr-line-break-types

After changing his EOL (end of line) from CR to CRLF, Windows BiblePay QT wallet read his configuration file correctly.

To reproduce:

1. Windows QT BiblePay, Tools, Debug Console, getmininginfo - you should have pool mining, CPID, etc working
2. In Notepad++, save biblepay.conf as Macintosh (CR) via Edit > EOL > Macintosh
3. Quit wallet
4. Start Wallet
5. Tools, Debug Console, getmininginfo - your previous getmininginfo should not match now

[biblepay]

People should not be saving a config file in mac format on a windows machine.

If this error can be reproduced on a mac please reopen, but we have mac users now mining thanks to MIPs mac release, so I believe their config is being read.

[fogoat]

I dont know where this originates. Let me see if I can test one click miner configuration and see what the hex viewer says

As I suspected, the default when you click One Click Mining Configuration this is where the "Macintosh" comes in. 0D0A is correct for Windows, but 0D is for Macintosh.

[nixcamic]

Can confirm this issue still exists. To clarify, nobody is saving as Mac format on purpose, rather the built in One Click Mining Config is in Mac format on the Windows wallet, so if you start from that Notepad/Notepad++ will automatically insert new newlines in Mac format. The bundled config needs to be fixed.

[MIPPL]

I’ll check it.

[fogoat]

I tried on 1.4.4.7o and still seems to be an issue. I'm using Windows 10.

https://github.com/biblepay/biblepay-evolution/commit/5f22676f576b98550009a64b756aa658490855b9