search

biblepay / biblepay_legacy

BiblePay
MIT License
35 stars 34 forks source link

Check miner/sanctuary payment mix in podc superblock payment #54

Closed biblepay closed 5 years ago

biblepay commented 5 years ago

In FillBlockPayees, it appears the sanc/miner mix is rewarding it to the miner and not regarding the sanctuary in coinbase payment vout[0] due to complicated business logic rules.

thesnat21 commented 5 years ago

did you get the data you needed from this? Sorry i've been distracted...

biblepay commented 5 years ago

Yes, checking to see how this came about today.

biblepay commented 5 years ago

Ok, so researching this, it turns out we probably just had a case of the Mandela effect. Dash doesn't pay the masternode either in superblocks - the miner gets all of vout[0] (the block reward). (I was apprehensive to change it until knowing it would be safe to change). The actual voting mechanism would need modified to ensure the vector at that height is not corrupted also. Since we will be inheriting deterministic masternodes in the future anyway, I'm sure we will be affected by the new governance process and we can inherit the next gen version at that time (IE no use going against the grain to fix something thats not really broken).

We just need to tell people Superblocks do not award sanctuary rewards.

Thanks....

thesnat21 commented 5 years ago

Ok, fair enough "working as intended" :)

Thanks for looking into this!