search

biblepay / biblepay_legacy

BiblePay
MIT License
35 stars 34 forks source link

Restrict wallet "upgrade" notification to production only releases. #60

Closed thesnat21 closed 5 years ago

thesnat21 commented 5 years ago

Someone commented on this, I think it's a good idea :)

vahtis commented 5 years ago

If we have separate download page for testnet I think this is not needed.

thesnat21 commented 5 years ago

Was thinking that after I put this up... Either method works, but if testnet vers are having issues better not to have it floating around production just in case.

fogoat commented 5 years ago

I think having binaries for windows is nice for ease of testing. If the testnet has different url to download then only those that seek it out are downloading it. No adverse affect running latest version in production but I suppose it's like Russian roulette :)

MIPPL commented 5 years ago

We are already working on it to separate master/develop branches for prod/testnet respectively.

biblepay commented 5 years ago

So MIP and I spoke at great length about this and decided it is a good idea to do this in two phases. Phase 1 : Rob has deployed a fix where the core client will now locate the last mandatory in Prod, and only notify the user if the client is outdated as compared to the last mandatory.

Over the next 6 months, MIP is going to look into our build scripts to locate a compiler tag that designates which branch built the core client. This way the core can also ignore the github version if the branch is not "main".

MIP feel free to re-open after the dash rebase is finished to finish phase 2.

biblepay commented 5 years ago

EDIT: In the next version, we have the ability to detect if the core version was built on a dev branch. Starting in 1197, the GetGithubVersion will also respect this flag and not show the false upgrade notification (in devnet branches).