search

biblepay / biblepay_legacy

BiblePay
MIT License
35 stars 34 forks source link

Wallet unlocks itself occasionally when mining with securestring password #62

Closed biblepay closed 5 years ago

biblepay commented 5 years ago

Dave_BBP has reported the wallet sometimes unlocks itself when using the PODCunlock password feature.

He is running win10 with 4 mining threads.

 The problem occurs in my Windows 10 Pro wallet (x64), currently version 71 (but not limited to that version). The config looks like this:

Code: shrinkdebug=1 gen=1 genproclimit=4 minersleep=1000

utxooverride=1463000

privatesendamount=20000

testnet=1

pool=https://pool.purepool.org workerid=B6fo71xAUr2gy2EBxVV69kUDxj7CH6CUXt/pc

pool=https://pool.biblepay.org

workerid=dave_pc

MIPPL commented 5 years ago

I'll take a look at it. The fact that it happens "occasionally" makes things harder... If someone finds a deterministic way to reproduce this, please report here.

MIPPL commented 5 years ago

I could not reproduce the problem but I found that if a SignStake call fails for whatever reason, wallet may be left unlocked. This would explain the apparent randomness of the issue.

Fix is in commit https://github.com/biblepay/biblepay/commit/f63bfff77ae628eed60dd86defc0a6f4f524190b

And will be merged into master soon