biblepay / biblepay_legacy

BiblePay
MIT License
35 stars 34 forks source link

Enhance: tithe output have one .001 output and the other output < 1 bbp #79

Closed fogoat closed 5 years ago

fogoat commented 5 years ago

vahtis said:

This is the thing I asked as new feature too. When tithing 8 bbp from lets say 2000.001 BBP coin it would be very nice to have 1992.001 BBP coin left

This would work only for integer tithes.

capulo said:

yes, something like vahtis wrote

this is my case . i had 500k, i did bankroll 100 5000. i already send one tithe from every pile (manualy or autotithe) and this is my actual state:

image

as you can see, there is no .001 suffix. so now i'm affraid if i use bankroll again, it will take these piles as they dont have .001 suffix

Rob answered:

when we create the Tithe transaction, instead of sending back the regular change, we do it like this:

User has 1000.001 bbp in the wallet User wants to tithe 3.05 bbp

Right now we send 3.05 bbp to Foundation and receive back change of 996.951

instead, we should:

A->To Foundation->3.05 B->To My "TITHE" address->996.0010 C->To ChangeAddress->.95

It should work like this for all tithes.

https://bitcointalk.org/index.php?topic=2388064.msg49872226#msg49872226

biblepay commented 5 years ago

Please test to ensure 1.1.9.3 completes this; in my testing it was successful.

fogoat commented 5 years ago

@biblepay I can't test But @vahtis said it works