search

bibletime / bibletime

:book: BibleTime is a powerful cross platform Bible study tool.
https://bibletime.info/
GNU General Public License v2.0
333 stars 68 forks source link

apocryphal Search Scopes not parsing correctly #250

Open Geremia opened 4 years ago

Geremia commented 4 years ago

When I add a new scope that mixes apocryphal books and non-apocryphal books, the parsed search range only includes the non-apocryphal books. For example:

Edit current range: Job-Sirach Parsed search range: Job 1:1-Revelation of John 22:21

Edit current range: Job-Wisdom Parsed search range: Job 1:1-Job 42:17

Apocryphal-only works:

Edit current range: Ecclesiasticus Parsed search range: Sirach 1:1-Sirach 51:38

BibleTime 3.0.0_rc1 on Linux 5.4.42, Qt 5.13.2.

Geremia commented 4 years ago

Starting with bibletime --debug, I now get

Segmentation fault

when I click the Search Scope "Setup" button.

gholmlund commented 4 years ago

The crash was fixed in bug #224. Adding the apocryphal scope works correctly as long as a apocyphal book is chosen in the Works field of the search dialog.

gholmlund commented 4 years ago

Please reopen if the comment above is not working for you.

Geremia commented 4 years ago

@gholmlund Your patch fixed the segfault issue (#224), but the mixed apocryphal & non-apocryphal Search Scopes issue is still there:

It now says:

Edit current range: Job-Sirach Parsed search range: Job 1:1-Nehemiah 13:31

gholmlund commented 4 years ago

To create the search scope, BibleTime must know the Work you will be searching. The module determines the available books and verses. As long as I set the Work while creating the search scope, it works for me. @Geremia Does it work if you set the apocryphal Work in the dialog?

Geremia commented 4 years ago

@gholmlund I can view apocryphal works just fine.

Also, I added a new search range with Job-Sirach, and now it parses that as Job 1:1-Revelation of John 22:21.