Repeated Nodes

[codykingham]

Acts contains a duplicate set of nodes:

See nodeId's 440150290150010-440150290150012

[jonathanrobie]

Thanks! This looks like a clear bug - even the nodeIDs are duplicated!

On Thu, Sep 1, 2016 at 7:48 AM, Cody Kingham notifications@github.com wrote:

Acts contains a duplicate set of nodes:

See nodeId's 440150290150010-440150290150012

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/biblicalhumanities/greek-new-testament/issues/13, or mute the thread https://github.com/notifications/unsubscribe-auth/ABr5vV0FoVEXrIz87AmCJldGrPrIcypqks5qlruHgaJpZM4JymlU .

[rkjtan]

This is a problem with how the automatic parser treats this kind of situation with only one word on its own in this kind of exact situation, which left 2 alternate trees. The tree that never promotes to a CL is the undesired one that should be discarded.

From: Jonathan Robie [mailto:notifications@github.com] Sent: Thursday, September 1, 2016 2:44 PM To: biblicalhumanities/greek-new-testament greek-new-testament@noreply.github.com Subject: Re: [biblicalhumanities/greek-new-testament] Repeated Nodes (#13)

Thanks! This looks like a clear bug - even the nodeIDs are duplicated!

On Thu, Sep 1, 2016 at 7:48 AM, Cody Kingham notifications@github.com<mailto:notifications@github.com> wrote:

Acts contains a duplicate set of nodes:

See nodeId's 440150290150010-440150290150012

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/biblicalhumanities/greek-new-testament/issues/13, or mute the thread https://github.com/notifications/unsubscribe-auth/ABr5vV0FoVEXrIz87AmCJldGrPrIcypqks5qlruHgaJpZM4JymlU .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/biblicalhumanities/greek-new-testament/issues/13#issuecomment-244222353, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFDhLhU-ioTINwZvXiWC7KbYCkvjbJhNks5ql0cpgaJpZM4JymlU.

[jonathanrobie]

It's easy enough for me to remove the duplicate nodes manually - is that the best approach?

On Thu, Sep 1, 2016 at 7:19 PM, rkjtan notifications@github.com wrote:

This is a problem with how the automatic parser treats this kind of situation with only one word on its own in this kind of exact situation, which left 2 alternate trees. The tree that never promotes to a CL is the undesired one that should be discarded.

From: Jonathan Robie [mailto:notifications@github.com] Sent: Thursday, September 1, 2016 2:44 PM To: biblicalhumanities/greek-new-testament <greek-new-testament@noreply. github.com> Subject: Re: [biblicalhumanities/greek-new-testament] Repeated Nodes (#13)

Thanks! This looks like a clear bug - even the nodeIDs are duplicated!

On Thu, Sep 1, 2016 at 7:48 AM, Cody Kingham <notifications@github.com< mailto:notifications@github.com>> wrote:

Acts contains a duplicate set of nodes:

See nodeId's 440150290150010-440150290150012

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/biblicalhumanities/greek-new-testament/issues/13, or mute the thread https://github.com/notifications/unsubscribe-auth/ ABr5vV0FoVEXrIz87AmCJldGrPrIcypqks5qlruHgaJpZM4JymlU .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ biblicalhumanities/greek-new-testament/issues/13#issuecomment-244222353, or mute the threadhttps://github.com/notifications/unsubscribe- auth/AFDhLhU-ioTINwZvXiWC7KbYCkvjbJhNks5ql0cpgaJpZM4JymlU.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/biblicalhumanities/greek-new-testament/issues/13#issuecomment-244241167, or mute the thread https://github.com/notifications/unsubscribe-auth/ABr5vYq5lGA-PHgTh2Y2eiVjgIwO03Aaks5ql11wgaJpZM4JymlU .

[jonathanrobie]

Fixed in Acts, but there are three other places with duplicate nodes:

2Tm4:1:1-4:1:21 Jms2:18:10-2:18:26 Jms2:20:1-2:20:14

Each one has two distinct trees. Randall, which one should be deleted in each case?

I wrote this query to check for duplicate nodes in trees:

for $n in //*[@nodeId] let $id := $n/@nodeId group by $id order by $id where count($n) > 1 return $n/@nodeId

All of the duplicate nodes were due to multiple Tree elements under Trees, which can easily be found using this query:

//Trees[count(Tree) > 1]

[rkjtan]

These 3 places are remnants of an experiment in allowing multiple trees that GBI has temporarily abandoned.

2Tm4:1:1-4:1:21 Delete the 2nd tree that has V-ADV-O Jms2:18:10-2:18:26 Delete the 2nd tree that has V-IO-O for the 1st clause Jms2:20:1-2:20:14 Delete the 2nd tree that has S-P-VC for the HOTI (last) clause

From: Jonathan Robie [mailto:notifications@github.com] Sent: Sunday, September 25, 2016 12:13 PM To: biblicalhumanities/greek-new-testament greek-new-testament@noreply.github.com Cc: rkjtan randall.tan@globalbibleinitiative.org; Comment comment@noreply.github.com Subject: Re: [biblicalhumanities/greek-new-testament] Repeated Nodes (#13)

Fixed in Acts, but there are three other places with duplicate nodes:

2Tm4:1:1-4:1:21 Jms2:18:10-2:18:26 Jms2:20:1-2:20:14

Each one has two distinct trees. Randall, which one should be deleted in each case?

I wrote this query to check for duplicate nodes in trees:

for $n in //*[@nodeId] let $id := $n/@nodeId group by $id order by $id where count($n) > 1 return $n/@nodeId

All of the duplicate nodes were due to multiple Tree elements under Trees, which can easily be found using this query:

//Trees[count(Tree) > 1]

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/biblicalhumanities/greek-new-testament/issues/13#issuecomment-249440331, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFDhLkAFL-LQTVl6fZW0oATR07yFwcjwks5qtse-gaJpZM4JymlU.

[jonathanrobie]

I have committed these changes for the full-fat trees.