biblicalhumanities / greek-new-testament

Greek New Testament
45 stars 18 forks source link

Add vocative role? #27

Closed jonathanrobie closed 7 years ago

jonathanrobie commented 7 years ago

I currently have a special case set of rules for vocative that treats words that are vocative much like words with an explicit role for the purpose of formatting:

w[case=vocative]::before {
  color: grey;
  content: "voc ";
  size: small;
}

w[case=vocative] {
    position: relative; 
    display: block;
    padding-left: 1em;
}

This does not work well for phrases that have a vocative function where not all words are vocative, and is especially problematic when we restore sentence order.

Consider the placement of μου in the following sentence:

screen shot 2017-04-26 at 5 08 23 pm

Thewg it is part of has no role attribute. This comes out much better if a vocative role attribute is added to the wg, deleting the special-cased rule for vocatives from the .css. And it looks even better if we restore sentence order here.

In Boxwood:

image

And in Treedown:

image

jonathanrobie commented 7 years ago

This proposal has been accepted. I have added this to parts of Matthew in Nestle1904, but it needs to be applied consistently across all files, and both Nestle1904 and SBLGNT.

An example:

screen shot 2017-05-19 at 4 23 44 pm

jonathanrobie commented 7 years ago

See https://github.com/biblicalhumanities/greek-new-testament/pull/29 for other examples of how to use the vocative role.