search

bic-ed / Multiverse

A responsive theme for Zenphoto
https://www.antonioranesi.it/pages/multiverse-zenphoto-theme/
Other
3 stars 3 forks source link

No need to require functions.php #3

Closed fretzl closed 4 years ago

fretzl commented 4 years ago

There is no need to "require" functions.php on line 5 of themeoptions.php. The file is loaded automatically.

bic-ed commented 4 years ago

Thanks! The reason why that line is there is that I started building theme options from themeoptions.php of ZP basic theme, where that line is still present actually! https://github.com/zenphoto/zenphoto/blob/342a19cb48fffc217f17e892147ea71c1e8fef80/themes/basic/themeoptions.php#L12 So it should be removed from there too?

fretzl commented 4 years ago

Sorry, my mistake. It's just that for you theme it's not necessary. The Basic and Garland themes do indeed need to "require" functions.php for certain custom options. I thought it was loaded automatically for all theme files but apparently not for themeoptions.php.

bic-ed commented 4 years ago

Thanks, I removed that line anyway and it doesn't harms. 367535f144bf79926b36fe43c1a190862109d3e8