search

bic-org-uk / bic-lcf

BIC Library Communication Framework
https://bic-org-uk.github.io/bic-lcf
Other
7 stars 4 forks source link

Inconsistency in the specification of Check-out / renewal responses in REST #276

Closed franciscave closed 3 years ago

franciscave commented 3 years ago

In v1.2.0 the element R11D01 loan-ref was removed and R11C02 loan was made mandatory. However, this is contradicted by the preceding text and by the following example, in which it is clear that the response can contain a loan-ref URI either in the Location field of the HTTP header or in the payload using R11D01.

I'm not sure that I can recall the intention here. The change was made in a commit on 14 August 2019. Was it our intention to mandate the inclusion of the loan record in the response? Further investigate is needed before we decide whether to reverse this change.

franciscave commented 3 years ago

For proposed resolution of this issue see pull request #278.