Potentiostat version

[ThomasHolmIFE]

Hi, I am testing the program to run a VSP-300 potentiostat. This is a class SP-300 potentiostat, but due to it being identified as a type: KBIO_DEV_VSP300, it will be identified as a VMP3 system (i.e., not KBIO-DEV_VSP300) when loading the .ecc files in the base_programs.py. This should thus be the 4.ecc files and not *.ecc. Is there a way to override this so the correct identification/class occurs?

Relevant code: line 425: "self._data_fields = ( dp.SP300_Fields.OCV if self.device.kind is ecl.DeviceCodes.KBIO_DEV_SP300 else dp.VMP3_Fields.OCV )"

[ThomasHolmIFE]

I see now that this is the same issue as Cdriko, so please ignore as the fix by Cdriko will be committed.

[bicarlsen]

Thanks for bringing that up as well. Perhaps you could pull @Cdriko's update and test it out before I pull it into the main code base.

[ThomasHolmIFE]

Hi bicarlsen,

I am not the most experienced user with github, but after cloning the package locally with Cdriko’s changes, I am able to successfully run a simple OCV and a CA program on my potentiostat (VSP-300). Thus, the fix fixes the potentiostat class problem and works fine for this.

Btw, thanks for putting in all the work in making the easy-biologic package! It is much appreciated!

Cheers, Thomas

From: bicarlsen @.> Sent: torsdag 3. mars 2022 19:37 To: bicarlsen/easy-biologic @.> Cc: Thomas Holm @.>; Author @.> Subject: Re: [bicarlsen/easy-biologic] Potentiostat version (Issue #15)

Thanks for bringing that up as well. Perhaps you could pull @Cdriko's updatehttps://github.com/bicarlsen/easy-biologic/pull/14 and test it out before I pull it into the main code base.

— Reply to this email directly, view it on GitHubhttps://github.com/bicarlsen/easy-biologic/issues/15#issuecomment-1058363776, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXSL2HVXKZHBCO6YOK4RZKDU6EBFDANCNFSM5P2VEQNQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.Message ID: @.**@.>>

[bicarlsen]

I updated @Cdriko's code a bit in Pull Request #16. If you have a chance to test out the updated code it would be greatly appreciated.

[ThomasHolmIFE]

Hey,

I can do this as soon as I make it to work again where the instrument is. I currently have corona, so don’t expect anything before Friday at the earliest.

Thomas

From: bicarlsen @.> Sent: fredag 4. mars 2022 18:54 To: bicarlsen/easy-biologic @.> Cc: Thomas Holm @.>; Author @.> Subject: Re: [bicarlsen/easy-biologic] Potentiostat version (Issue #15)

I updated @Cdrikohttps://github.com/Cdriko's code a bit in Pull Request #16https://github.com/bicarlsen/easy-biologic/pull/16. If you have a chance to test out the updated code it would be greatly appreciated.

— Reply to this email directly, view it on GitHubhttps://github.com/bicarlsen/easy-biologic/issues/15#issuecomment-1059388175, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXSL2HRLFSD4U6JNTF7RKCTU6JE3NANCNFSM5P2VEQNQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.Message ID: @.**@.>>

[ThomasHolmIFE]

Hi bicarlsen,

I have tested the latest version now, and it seems to work as intended with a very simple program (connect to VSP-300, run a single technique (CA), and print data in cmd).

Cheers, Thomas

From: bicarlsen @.> Sent: fredag 4. mars 2022 18:54 To: bicarlsen/easy-biologic @.> Cc: Thomas Holm @.>; Author @.> Subject: Re: [bicarlsen/easy-biologic] Potentiostat version (Issue #15)

I updated @Cdrikohttps://github.com/Cdriko's code a bit in Pull Request #16https://github.com/bicarlsen/easy-biologic/pull/16. If you have a chance to test out the updated code it would be greatly appreciated.

— Reply to this email directly, view it on GitHubhttps://github.com/bicarlsen/easy-biologic/issues/15#issuecomment-1059388175, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXSL2HRLFSD4U6JNTF7RKCTU6JE3NANCNFSM5P2VEQNQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.Message ID: @.**@.>>

[bicarlsen]

Awesome :) Thanks so much. I should update the package in the coming days then.

[bicarlsen]

These changes have been added in easy-biologic v0.3.3.