search

bicarlsen / easy-biologic

Python library for communicating with Biologic devices.
GNU General Public License v3.0
18 stars 11 forks source link

Not an issue, but a question about techniques #20

Closed ThomasHolmIFE closed 2 years ago

ThomasHolmIFE commented 2 years ago

I haven't checked to carefully, but as I remember from EC-lab documentation there is some limit to which techniques that can be implemented (not PEIS with multisine option for example). Do you know if this is the case for adding the GEIS technique (Galvanostatic Electrochemical Impedance Spectroscopy)? If it is possible, I can give it a try to add it.

bicarlsen commented 2 years ago

There is a GEIS technique included in the EC Lab Development kit (Section 7.13 in the EC-Lab Development Users Guide Version 6.00), and the techinque binary is included in the easy_biologic package. I imagine you can use the PEIS technique as a template and easily adapt it for the GEIS technique.

ThomasHolmIFE commented 2 years ago

Hi, I've given this a try and added a pull request for adding the tecnhique. Please look through the formatting etc to unify with the rest of the code.

I also had a test script, which was also added, but shouldn't be part of the main branch. Not sure how to remove it without also removing it locally.

ThomasHolmIFE commented 2 years ago

The technique has been tested locally here with a VSP-300 system. It would probably be worthwhile to test also on other systems, but with the addition of the instrument classes in February, I think this should work well then as well.

bicarlsen commented 2 years ago

These changes are included in version 0.3.4.