bicarlsen / easy-biologic

Python library for communicating with Biologic devices.
GNU General Public License v3.0
18 stars 11 forks source link

Modification on CV scanning in base_programs #33

Closed DangerLin closed 1 month ago

DangerLin commented 2 months ago

Hi @bicarlsen, some minor modifications were included here. Following are the changes:

  1. Update CV_scan in base_programs.py. Use "CV" to replace "JV_Scan" for less confusion.

  2. Add folder techniques-6.08 and update technique_version.

  3. In ec_lib.py, following device codes (DeviceCodes) were added:

    KBIO_DEV_BP300 = 32
    KBIO_DEV_VMP3e = 33
    KBIO_DEV_VSP3e = 34
    KBIO_DEV_SP50E = 35
    KBIO_DEV_SP150E = 36
  1. In ec_lib.py, following device code descriptions (DeviceCodeDescriptions) were added:
   KBIO_DEV_BP300 = 'BP-300 (VMP300)'
    KBIO_DEV_VMP3e = 'VMP-3e (VMP3)'
    KBIO_DEV_VSP3e = 'VSP-3e (VMP3)'
    KBIO_DEV_SP50E = 'SP-50e (VMP3)'
    KBIO_DEV_SP150E = 'SP-150e (VMP3)'
  1. In ec_lib.py, following VMP3_DEVICE_FAMILY were added:
    DeviceCodes.KBIO_DEV_VMP3e,
    DeviceCodes.KBIO_DEV_VSP3e,
    DeviceCodes.KBIO_DEV_SP50E,
    DeviceCodes.KBIO_DEV_SP150E

following SP300_DEVICE_FAMILY were added:

    DeviceCodes.KBIO_DEV_BP300
  1. In ec_lib.py, comments were added in DeviceInfo, ChannelInfo, EccParam, CurrentValues.

  2. Examples of CV scanning and PEIS test were added in ReadMe.md file.

bicarlsen commented 2 months ago

Awesome! Thanks for all the changes.

  1. Have you tested the changes to ensure they are all working?
  2. Please bump the version to 0.4.0 due to the breaking changes.
DangerLin commented 2 months ago

Awesome! Thanks for all the changes.

  1. Have you tested the changes to ensure they are all working?
  2. Please bump the version to 0.4.0 due to the breaking changes.

Yes, we've tested the changes for several months (typically for CV, OCV, PEIS, and CA testing), everything goes well. I have bumped the version to 0.4.0 and updated the techniques-6.08 folder; also, some error codes were added into ec_error.py. Thank you!

bicarlsen commented 1 month ago

Thanks for the updates! I just released v0.4.0 on PyPI.

DangerLin commented 1 month ago

Thank you for this great package!