search

bicarlsen / easy-biologic

Python library for communicating with Biologic devices.
GNU General Public License v3.0
18 stars 11 forks source link

Inconsistency in the variable name in CP #8

Closed chemyibinjiang closed 2 years ago

chemyibinjiang commented 2 years ago

Hello, In the run function of CP class, the maximum current is defined as i_max = max( currents ) while a large amount of the later if statement compares the scale of max_i , which might be some error during the function definition. It would be good if this can be corrected :)

bicarlsen commented 2 years ago

Great catch :) Thank you. I have updated this in commit 690e180.