biddyweb / substruct

Automatically exported from code.google.com/p/substruct
0 stars 0 forks source link

SAMPLE Simpler navigation bar highlight code. #46

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
I substituted all methods that does the highlight by just one, as nothing
is broken this is not a fix. I think this way its much more simpler to
understand, the functionality should be the same. It was changed directly
inside /vendor/plugins/substruct.

Follows a diff, my working copy is so messed with changes not committed
that its hard to separate issues that I filled to make a diff just with one :P

It needs that app/controllers/application.rb be this:

class ApplicationController < ActionController::Base
  include SubstructApplicationController  
  before_filter :set_navigation_tabs
  before_filter :find_customer
end

This change is out of the scope of the subversion repository.

Original issue reported on code.google.com by edmundo...@gmail.com on 12 Mar 2008 at 3:36

Attachments:

GoogleCodeExporter commented 9 years ago
The last patch broke tab highlight inside the admin module as it needs @cname 
and
@aname too. Greping the code shows that its used only in the admin layout, it 
should
work now.

Follows the previous patch fixed.

Original comment by edmundo...@gmail.com on 13 Mar 2008 at 5:22

Attachments:

GoogleCodeExporter commented 9 years ago
Not really the way I'd like to see this solved. By cleaning up I meant removing 
more crap from the 
application_controller.

Don't like this approach, so I'm rejecting & setting to a low priority.

Original comment by subim...@gmail.com on 9 Apr 2008 at 6:27

GoogleCodeExporter commented 9 years ago
Is there a way to combine this with issue 45?

Original comment by subim...@gmail.com on 9 Apr 2008 at 8:07

GoogleCodeExporter commented 9 years ago
I don't understood why, its two different things, is really issue 45 that you 
are
talking about?

Issue 45 is just a change in a "find" call to not break a test or break the 
interface
when the database wasn't populated using the administration interface (I 
normally
import fixtures in the development environment with random ids (foxy fixtures 
dont
need to have ids) to start to work with the interface).

Original comment by edmundo...@gmail.com on 9 Apr 2008 at 10:36