bids-apps / freesurfer

BIDS app wrapping recon-all from FreeSurfer
Apache License 2.0
41 stars 35 forks source link

T2 and T2 failure modes with multiple input #20

Closed alexlicohen closed 7 years ago

alexlicohen commented 7 years ago

if there are multiple T2 or FLAIR images in the directory structure, the T2pial or FLAIRpial stages do not seem to be run.

Additionally, if multiple T1s are provided, but of different resolution, freesurfer crashes.

I'm thinking to write an additional switch to select the BIDS -rec_xyz- tags to designate a particular image to use and/or users can generate their own averages and assign them a -rec_avg- tag

i.e., labeling files as sub-003_ses-01_acq-mprage_rec-forFS_run-01_T1w.nii.gz or sub-003_ses-01_acq-mprage_rec-avg_T1w.nii.gz

chrisgorgo commented 7 years ago

On Wed, Jan 25, 2017 at 8:22 AM, Alexander Li Cohen < notifications@github.com> wrote:

if there are multiple T2 or FLAIR images in the directory structure, the T2pial or FLAIRpial stages do not seem to be run.

That's not good - what's the traceback?

Additionally, if multiple T1s are provided, but of different resolution, freesurfer crashes.

This is expected freesurfer behaviour. Last time I checked on the mailing list using multiple T1s coming from different acqusitions is not recommended.

I'm thinking to write an additional switch to select the BIDS -rec_xyz- tags to designate a particular image to use and/or users can generate their own averages and assign them a -rec_avg- tag

i.e., labeling files as sub-003_ses-01_acq-mprage_re c-forFS_run-01_T1w.nii.gz or sub-003_ses-01_acq-mprage_rec-avg_T1w.nii.gz

We already have --acquisition_label ACQUISITION_LABEL that can be used to do that. Why would users want to make their own averages?

You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BIDS-Apps/freesurfer/issues/20, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOkp-K3GiFaWvsVn8Rw9_c7bxobAI4Xks5rV3aqgaJpZM4Ltr3U .

alexlicohen commented 7 years ago

For the multiple T2s, I believe it might just be the -T2pial flag being repeated, in testing now... for the T1s, sometimes the acq is the same, but the field of view was different... this could be handled off line with anew acq code though...

-Alex

On Jan 25, 2017, at 11:28 AM, Chris Filo Gorgolewski notifications@github.com wrote:

On Wed, Jan 25, 2017 at 8:22 AM, Alexander Li Cohen < notifications@github.com> wrote:

if there are multiple T2 or FLAIR images in the directory structure, the T2pial or FLAIRpial stages do not seem to be run.

That's not good - what's the traceback?

Additionally, if multiple T1s are provided, but of different resolution, freesurfer crashes.

This is expected freesurfer behaviour. Last time I checked on the mailing list using multiple T1s coming from different acqusitions is not recommended.

I'm thinking to write an additional switch to select the BIDS -rec_xyz- tags to designate a particular image to use and/or users can generate their own averages and assign them a -rec_avg- tag

i.e., labeling files as sub-003_ses-01_acq-mprage_re c-forFS_run-01_T1w.nii.gz or sub-003_ses-01_acq-mprage_rec-avg_T1w.nii.gz

We already have --acquisition_label ACQUISITION_LABEL that can be used to do that. Why would users want to make their own averages?

You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BIDS-Apps/freesurfer/issues/20, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOkp-K3GiFaWvsVn8Rw9_c7bxobAI4Xks5rV3aqgaJpZM4Ltr3U .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

chrisgorgo commented 7 years ago

On Wed, Jan 25, 2017 at 9:07 AM, Alexander Li Cohen < notifications@github.com> wrote:

For the multiple T2s, I believe it might just be the -T2pial flag being repeated, in testing now... for the T1s, sometimes the acq is the same, but the field of view was different... this could be handled off line with anew acq code though...

Yes if the field of view is different it should be a new acq label.

-Alex

On Jan 25, 2017, at 11:28 AM, Chris Filo Gorgolewski < notifications@github.com> wrote:

On Wed, Jan 25, 2017 at 8:22 AM, Alexander Li Cohen < notifications@github.com> wrote:

if there are multiple T2 or FLAIR images in the directory structure, the T2pial or FLAIRpial stages do not seem to be run.

That's not good - what's the traceback?

Additionally, if multiple T1s are provided, but of different resolution, freesurfer crashes.

This is expected freesurfer behaviour. Last time I checked on the mailing list using multiple T1s coming from different acqusitions is not recommended.

I'm thinking to write an additional switch to select the BIDS -rec_xyz- tags to designate a particular image to use and/or users can generate their own averages and assign them a -rec_avg- tag

i.e., labeling files as sub-003_ses-01_acq-mprage_re c-forFS_run-01_T1w.nii.gz or sub-003_ses-01_acq-mprage_rec-avg_T1w.nii.gz

We already have --acquisition_label ACQUISITION_LABEL that can be used to do that. Why would users want to make their own averages?

You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BIDS-Apps/freesurfer/issues/20, or mute the thread https://github.com/notifications/unsubscribe- auth/AAOkp-K3GiFaWvsVn8Rw9_c7bxobAI4Xks5rV3aqgaJpZM4Ltr3U .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/BIDS-Apps/freesurfer/issues/20#issuecomment-275168066, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOkpwUGs82_D5xCA00yX6oES6Dn_H24ks5rV4E9gaJpZM4Ltr3U .

alexlicohen commented 7 years ago

The T2 pial failure I was encountering is not related to the BIDS-App code, it's within freesurfer itself (the -pial stage, specifically mris_make_surfaces was failing with my test case... still figuring out why...) so this issue can be closed, I will, however, make a pull request to add in an acquisition label switch for the T2/FLAIR sequence too (since that may be helpful to others).

chrisgorgo commented 7 years ago

Thank you!

On Thu, Jan 26, 2017 at 6:24 PM, Alexander Li Cohen < notifications@github.com> wrote:

Closed #20 https://github.com/BIDS-Apps/freesurfer/issues/20.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/BIDS-Apps/freesurfer/issues/20#event-938761334, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOkp9nrPrPA44yNRcmPED5YJ46qUfM7ks5rWVVZgaJpZM4Ltr3U .