Closed PeerHerholz closed 1 year ago
Yeah, I think that'd be great, but I haven't set those up before, so I don't know how much I'd be able to help.
On Thu, Jun 18, 2020 at 4:17 PM Peer Herholz notifications@github.com wrote:
While we're have tests running, we could/should also include automated builds through the dockerhub-github integration that follows specific build rules for e.g. latest vs. specific versions. WDYT @Shotgunosine https://github.com/Shotgunosine?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BIDS-Apps/freesurfer/issues/59, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABILLGDKZ5OL5VMII2W4VGDRXJY67ANCNFSM4OCDX2PQ .
KK, I'll check it out and keep you posted here. @chrisgorgo sorry for stressing again, but do you know who owns the account for the bids organization on dockerhub?
@effigies Do you know who owns the bids organization on dockerhub?
@PeerHerholz The circleci config should be pushing to github, do you see any error messages in any of the circleci jobs that get triggered after merging?
I suspect it's Chris, but IDK for sure. @yarikoptic and @tyarkoni might also know?
All I know is it isn't me... I would also guess @chrisgorgo.
@Shotgunosine just checked and didn't see any error messages.
@PeerHerholz oh, you may have to tag a release to trigger it. You can created an annotated tag with git tag -a v1.4 -m "my version 1.4"
with whatever version we want to call this release (I guess 6.0.1-6 if we want to follow Chris's pattern) and git push --tags
to push it up to the repo.
Ah I see, sorry for not checking more closely. Do you want to do a release based on the current status or wait for some more additions, e.g. automated builds?
I think a release based on where we are now would be good.
On Tue, Jun 30, 2020 at 2:24 PM Peer Herholz notifications@github.com wrote:
Ah I see, sorry for not checking more closely. Do you want to do a release based on the current status or wait for some more additions, e.g. automated builds?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BIDS-Apps/freesurfer/issues/59#issuecomment-651964753, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABILLGBDD3EXUOJJAAQQUQLRZIUV3ANCNFSM4OCDX2PQ .
I don't know much about the github integrations, but I do think we could also achieve side by side builds of v6.0.1 and v 7.0.1 with circleci if we wanted to go that route.
Yeah, I thought the same. I haven't done a lot with v 7.0.1
yet and thus don't know if we would need to have parallel docs
and examples
as well?
I'm not sure. We could always stand one up and see if people start finding broken things.
I believe this has been taken care of.
While we're have tests running, we could/should also include automated builds through the dockerhub-github integration that follows specific build rules for e.g.
latest
vs.specific
versions. WDYT @Shotgunosine?