bids-apps / freesurfer

BIDS app wrapping recon-all from FreeSurfer
Apache License 2.0
40 stars 35 forks source link

Introduce automated image builds #59

Closed PeerHerholz closed 1 year ago

PeerHerholz commented 4 years ago

While we're have tests running, we could/should also include automated builds through the dockerhub-github integration that follows specific build rules for e.g. latest vs. specific versions. WDYT @Shotgunosine?

Shotgunosine commented 4 years ago

Yeah, I think that'd be great, but I haven't set those up before, so I don't know how much I'd be able to help.

On Thu, Jun 18, 2020 at 4:17 PM Peer Herholz notifications@github.com wrote:

While we're have tests running, we could/should also include automated builds through the dockerhub-github integration that follows specific build rules for e.g. latest vs. specific versions. WDYT @Shotgunosine https://github.com/Shotgunosine?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BIDS-Apps/freesurfer/issues/59, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABILLGDKZ5OL5VMII2W4VGDRXJY67ANCNFSM4OCDX2PQ .

PeerHerholz commented 4 years ago

KK, I'll check it out and keep you posted here. @chrisgorgo sorry for stressing again, but do you know who owns the account for the bids organization on dockerhub?

Shotgunosine commented 4 years ago

@effigies Do you know who owns the bids organization on dockerhub?

Shotgunosine commented 4 years ago

@PeerHerholz The circleci config should be pushing to github, do you see any error messages in any of the circleci jobs that get triggered after merging?

effigies commented 4 years ago

I suspect it's Chris, but IDK for sure. @yarikoptic and @tyarkoni might also know?

tyarkoni commented 4 years ago

All I know is it isn't me... I would also guess @chrisgorgo.

PeerHerholz commented 4 years ago

@Shotgunosine just checked and didn't see any error messages.

Shotgunosine commented 4 years ago

@PeerHerholz oh, you may have to tag a release to trigger it. You can created an annotated tag with git tag -a v1.4 -m "my version 1.4" with whatever version we want to call this release (I guess 6.0.1-6 if we want to follow Chris's pattern) and git push --tags to push it up to the repo.

PeerHerholz commented 4 years ago

Ah I see, sorry for not checking more closely. Do you want to do a release based on the current status or wait for some more additions, e.g. automated builds?

Shotgunosine commented 4 years ago

I think a release based on where we are now would be good.

On Tue, Jun 30, 2020 at 2:24 PM Peer Herholz notifications@github.com wrote:

Ah I see, sorry for not checking more closely. Do you want to do a release based on the current status or wait for some more additions, e.g. automated builds?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BIDS-Apps/freesurfer/issues/59#issuecomment-651964753, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABILLGBDD3EXUOJJAAQQUQLRZIUV3ANCNFSM4OCDX2PQ .

Shotgunosine commented 4 years ago

I don't know much about the github integrations, but I do think we could also achieve side by side builds of v6.0.1 and v 7.0.1 with circleci if we wanted to go that route.

PeerHerholz commented 4 years ago

Yeah, I thought the same. I haven't done a lot with v 7.0.1 yet and thus don't know if we would need to have parallel docs and examples as well?

Shotgunosine commented 4 years ago

I'm not sure. We could always stand one up and see if people start finding broken things.

Remi-Gau commented 1 year ago

I believe this has been taken care of.