search

bids-apps / freesurfer

BIDS app wrapping recon-all from FreeSurfer
Apache License 2.0
40 stars 35 forks source link

deploy failure #62

Closed PeerHerholz closed 4 years ago

PeerHerholz commented 4 years ago

@Shotgunosine as suggested, I did a new release and "luckily" that resolved in an error that points to further updates that should be done. Within the deploy part, the following is failing: 

#!/bin/bash -eo pipefail
if [[ -n "$DOCKER_PASS" ]]; then docker login -e $DOCKER_EMAIL -u $DOCKER_USER -p $DOCKER_PASS && docker push bids/${CIRCLE_PROJECT_REPONAME}:latest; fi 
if [[ -n "$DOCKER_PASS" ]]; then docker login -e $DOCKER_EMAIL -u $DOCKER_USER -p $DOCKER_PASS && docker tag bids/${CIRCLE_PROJECT_REPONAME} bids/${CIRCLE_PROJECT_REPONAME}:$CIRCLE_TAG && docker push bids/${CIRCLE_PROJECT_REPONAME}:$CIRCLE_TAG; fi

with the error unknown shorthand flag: 'e' in -e, which is due docker removing this argument since the last time a new version was released. We'll need to adapt these parts accordingly.

PeerHerholz commented 4 years ago

@Shotgunosine, you did it again: all tests pass now. I had to trigger the whole set of tests/deploy process through a minimal release. Thx.