search

bids-apps / giga_connectome

generate connectome from fMRIPrep outputs
https://giga-connectome.readthedocs.io/en/stable/
MIT License
4 stars 4 forks source link

Document contributors and their roles #161

Open shnizzedy opened 1 month ago

shnizzedy commented 1 month ago

Your idea

As part of https://github.com/openjournals/joss-reviews/issues/7061#issuecomment-2258789463, I'm asked to verify

Does the full list of paper authors seem appropriate and complete?

The answer to that question isn't easily apparent to me. For the JOSS submission and generally, having the contributors and their roles clearly documented would be helpful.

I can see from this repo's contributor graph that Hao-Ting and Rémi contributed significantly to the code, but it's unclear what other roles they and the other authors contributed (or if that information is documented, it's not particularly easy to find).

For the purposes of the review, I think just responding to this issue is probably sufficient, but using something like All Contributors or CRediT in the README and/or documentation would be a more sustainable (and broadly useful) solution.

htwangtw commented 1 month ago

Thanks for suggesting @shnizzedy! All contributors would be a good addition indeed.

QD contributed on the code to containerised the BIDS app. NC tested the software by deploying it on 10+ datasets, caught bugs, and helped improved the features (see issue #36 #54 #106 for examples) PB provided direction of design, such as adopting BIDS convention, and scope of the features.