search

bids-apps / oppni

runs fast optimization of preprocessing pipelines for BOLD fMRI
Apache License 2.0
5 stars 3 forks source link

Docker Not Using Cache in Subsequent Builds #3

Closed raamana closed 8 years ago

raamana commented 8 years ago

It is somewhat strange why Docker is not using previous builds from the cache in the subsequent calls of circle CI.

Hey @chrisfilo , can you take a look at https://github.com/BIDS-Apps/oppni/blob/master/circle.yml#L20 and see if something needs to be changed to reduce the build times?

Thanks.

chrisgorgo commented 8 years ago

Yeah - I noticed this as well recently. I'm not sure why is this happening: we are following their guidelines: https://circleci.com/docs/docker/#caching-docker-layers

chrisgorgo commented 8 years ago

I see the problem: https://github.com/docker/docker/issues/20380 - it's the docker version. I'll try to downgrade it to 1.9 on bids/example and see if this fixes the problem.

raamana commented 8 years ago

Cool. Good to know we know the source of the problem.

I will wait for your heads up before rebuilding.

raamana commented 8 years ago

Hey @chrisfilo I don't think your changes fixed it. The latest build is still redoing everything: https://circleci.com/gh/BIDS-Apps/oppni/24

chrisgorgo commented 8 years ago

I expect circle requires at least one successful test run for the cache to be stored and passed to a new build. Currently oppni fails on other tests (unrelated to docker build. You can try to disable them temporarily.

Downgrading to docker 1.8 did fix the caching issue in other repos (see https://circleci.com/gh/BIDS-Apps/example/48)

On Sat, Aug 6, 2016 at 10:18 PM, Pradeep Reddy Raamana < notifications@github.com> wrote:

Reopened #3 https://github.com/BIDS-Apps/oppni/issues/3.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BIDS-Apps/oppni/issues/3#event-747606522, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOkp9Nzu_CbP-qNfhwkJwPAXIVccfu3ks5qdWqrgaJpZM4JeWYQ .

raamana commented 8 years ago

I see. I will do so.

chrisgorgo commented 8 years ago

Hey - it works! https://circleci.com/gh/BIDS-Apps/oppni/26

On Sun, Aug 7, 2016 at 9:15 AM, Pradeep Reddy Raamana < notifications@github.com> wrote:

I see. I will do so.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BIDS-Apps/oppni/issues/3#issuecomment-238091369, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOkpzjdX_MI12eH0b6Qh8qWq21TcCqCks5qdgSfgaJpZM4JeWYQ .

raamana commented 8 years ago

It did :). The funny thing is it didn't rebuild the docker image this time, which we were expecting it to do.

Thanks for the pointers to get the build here.