bids-standard / BEP028_BIDSprov

Organizing and coordinating BIDS extension proposal 28 : BIDS Provenance
https://bids.neuroimaging.io/bep028
Creative Commons Attribution 4.0 International
4 stars 13 forks source link

add blocs which concatenate activities for afni parser #105

Closed cyril-data closed 1 year ago

cyril-data commented 1 year ago

This PR concatenates activities in blocs define by the start of "# ====== ..." in logs of afni.

cmaumet commented 1 year ago

Thank you both! I have one quick question about how this works in practice. With this new updated, we have 1 block == 1 activity (instead of 1 command == 1 activity), can you tell me how are inputs/outputs dealt with? Specifically: 1- are we still defining inputs/outputs at the command level (and then the block knows which commands are in that block and can deduce its inputs/ouptus) 2- is there a new mecanism at the block level 3- another solution?

Thanks!

cyril-data commented 1 year ago

Hi @cmaumet ,

This is exactly the hypothesis 1- are we still defining inputs/outputs at the command level (and then the block knows which commands are in that block and can deduce its inputs/ouptuts)

The activities and their associated entities (inputs or outputs), are read and assembled in a graph as usual. But in parallel, at the reading procedure of the afni log file, we have associated each activity to a block : we know which commands are in each block. And so, we can deduce the block inputs and ouptuts and build a new block graph, deleting all intermediate entities inside the block.

Cheers

cmaumet commented 1 year ago

Awesome thanks @cyril-data!