bids-standard / BEP028_BIDSprov

Organizing and coordinating BIDS extension proposal 28 : BIDS Provenance
https://bids.neuroimaging.io/bep028
Creative Commons Attribution 4.0 International
4 stars 12 forks source link

FSL : harmonization with SPM and cleaning up the project structure #87

Closed thomasbtnfr closed 1 year ago

thomasbtnfr commented 1 year ago

Important note: this PR is built on https://github.com/bids-standard/BEP028_BIDSprov/pull/85. https://github.com/bids-standard/BEP028_BIDSprov/pull/85 must be reviewed and merged first


The purpose of this pull request is to implement the same processes on the FSL parser as those in SPM. This includes:

In addition, this pull request reworks the reading of FSL log files. Indeed, in accordance with this issue, some lines were not read such as those containing numbers that stopped the reading for a particular step. Furthermore, lines starting with did not find were read and according to our discussion of 17/01, they should not be read. This has been corrected.

thomasbtnfr commented 1 year ago

Conflicts have been resolved. The PR is ready to be reviewed.

cmaumet commented 1 year ago

(Note: I am merging this now so that I can more easily review the FSL examples --- @thomasbtnfr when you can would be great if you can address the two tiny comments above, thx!)