search

bids-standard / bep001

Project management repository (primarily issues) for BIDS Extension Proposal 001
Creative Commons Attribution 4.0 International
8 stars 11 forks source link

Rename sequence label to modality label #3

Closed KirstieJane closed 5 years ago

KirstieJane commented 6 years ago

To be discussed in August call.

Gilles86 commented 5 years ago

Has this now been agreed upon or not? Not clear to me from August notes.

KirstieJane commented 5 years ago

There's a table in BIDS that uses modality_label already: https://bids-specification.readthedocs.io/en/latest/04-modality-specific-files/01-magnetic-resonance-imaging-data.html

Gilles86 commented 5 years ago

In the latest version of pybids, this is actually called a suffix. https://github.com/bids-standard/pybids/blob/master/examples/pybids%20tutorial.ipynb

Gilles86 commented 5 years ago

See https://github.com/bids-standard/bep001/commit/48a784b349b5f24c3acb3de5b407fe9c1333f7ac

Gilles86 commented 5 years ago

Adressed in pull request https://github.com/bids-standard/bep001/pull/13/