bids-standard / bep001

Project management repository (primarily issues) for BIDS Extension Proposal 001
Creative Commons Attribution 4.0 International
8 stars 11 forks source link

Re-organizing suffix section and other improvements [WIP] #59

Open agahkarakuzu opened 5 years ago

agahkarakuzu commented 5 years ago
KirstieJane commented 4 years ago

>>>> TO BE DISCUSSED START __


Good practice recommendations:

Parameters that are unchanged across the constituents of a grouped scan collection MAY repeat in every JSON file belonging to that group. To avoid such redundancy, all the fixed metadata fields MAY be included only in the JSON file of the first member of a grouped scan collection, where constituent images are sorted in ascending alphabetical order. If this convention is followed, then the remaining JSON files MAY only contain parameters that are subjected to at least one change across all the member images.


TO BE DISCUSSED END <<<<


@Gilles86 and I are reviewing this PR and although we can see the benefits of not having to write out the same metadata over and over, we both agree that this proposal breaks the inheritance principle and ends up being much more complicated to implement 😭

I've deleted it for now....sorry @agahkarakuzu! I hope that's ok 😬