Enforce phase images within certain range?

bids-standard / bep001

Project management repository (primarily issues) for BIDS Extension Proposal 001

Creative Commons Attribution 4.0 International

8 stars 11 forks source link

Enforce phase images within certain range? #6

Closed Gilles86 closed 5 years ago

Gilles86 commented 6 years ago

I think it would be good to enforce within BIDS that phase images are always constrained to (0, 2pi] radians (including 0, excluding 2 pi). This makes it easier to, e.g., fit qMRI models. What do you guys think?

KirstieJane commented 5 years ago

This makes sense to me! Happy to hear others' opinions though!

The main BIDS spec has some phase images in it already (for the field maps) so we'd just need to find where exactly makes sense to add that information.

https://bids-specification.readthedocs.io/en/latest/04-modality-specific-files/01-magnetic-resonance-imaging-data.html#two-phase-images-and-two-magnitude-images

Gilles86 commented 5 years ago

See https://github.com/bids-standard/bep001/commit/d6bab3b4d4b9c9898d0756e73a008cddfe272c21 for a proposal

Gilles86 commented 5 years ago

Reworked this to a pull request based on @agahkarakuzu's work.

Gilles86 commented 5 years ago

(I think I need to do this again, rebased on the current master-branch.)

Gilles86 commented 5 years ago

https://github.com/bids-standard/bep001/pull/39