Fixes around magnitude/phase images

bids-standard / bep001

Project management repository (primarily issues) for BIDS Extension Proposal 001

Creative Commons Attribution 4.0 International

8 stars 11 forks source link

Fixes around magnitude/phase images #63

Open Lestropie opened 5 years ago

Lestropie commented 5 years ago

Went looking for the most up-to-date information on incorporation of magnitude / phase image pair data into BIDS, and stumbled across a few minor issues.

Split across individual commits for clarity of commit messages.

KirstieJane commented 5 years ago

Sorry for all these ups and downs - my view on github isn't updating the view on master correctly - it's stale 😬 - UPDATE - urgh - my fault - master has this merge conflict. I'll fix that now 😄

But thank you @Lestropie for suggesting the change. @Gilles86 - can you review? Will there ever be data that has phase stored in units that are not in radians?

KirstieJane commented 5 years ago

Fixed the merge conflict. Ridiculously hard to do - and I wrote to your branch @Lestropie! hope that's ok 😸

Gilles86 commented 4 years ago

Ready to merge. What you @KirstieJane ?