bids-standard / bids-2-devel

Discussions and suggestions of backwards incompatible changes to BIDS
https://bids.neuroimaging.io/
Creative Commons Attribution 4.0 International
10 stars 1 forks source link

Replace ce entity with one that applies to MRI and PET data equally well #46

Closed tsalo closed 3 years ago

tsalo commented 3 years ago

Currently, MRI uses ce (contrast enhancing agent) to indicate exogenous chemicals used to enhance contrasts, while the PET BEP, which uses tracers, plans to use the acq entity because ce doesn't reflect common terminology for PET users.

I propose that we define a new entity, perhaps called tracer, that would work for both technologies and would replace ce.

The addition of a tracer entity was proposed by @mnoergaard in https://github.com/bids-standard/bids-specification/pull/633#discussion_r563794146. In the hopes of not cluttering up the specification with a new entity in BIDS 1.X, I think it would be best to replace the existing ce in 2.0.

effigies commented 3 years ago

If "tracer" works for both contexts, I would support moving to that. Difficult to shorten to 2-3 characters (trc, maybe?), but perhaps also unlikely to be concatenated with so many other entities that a 6 character entity would lead to unreadable filenames.

melanieganz commented 3 years ago

So from the PET perspective tracer would be good and shortening it to trc would be fine, but not great in terms of readability. But are the MR people OK to call a contrast-enhancing agent a tracer? That seems slightly misleading to me. E.g. here they call it moelcular tracers or contrast agents (https://www.bruker.com/content/bruker/int/en/applications/academia-life-science/imaging/in-vivo-imaging/molecular-tracers-and-contrast-agents.html)

tsalo commented 3 years ago

It would be good to get input from MR folks who use contrast-enhancing agents. I don't know anyone who does though.

EDIT: I've posted to the bids-discussion Google Group (see here).

nicholst commented 3 years ago

This is going to be really hard because, just linquistically, the two core terms are really different.

For MRI injections "contrast agent" is ubiquetous in MRI and implicit with the passive nature of the injection. In PET, the injection is the very source of the signal... a better analogy is: What is the BIDS language for the chemical species imaged (i.e. the origin of the MRI signal)?

(please, someone who knows more about MRI edit the names I've assigned if I've mangled it.)

In short, I don't think we should try to harmonise this. Contrast agent ce is something that modifies the MRI signal, and BIDS 2.0 for PET should create a new label, e.g. trc, for the origin of the PET signal. And we should probably have yet a new keyword for chemical species of the MRI sequence.

melanieganz commented 3 years ago

Since we haven't finished the actual PET BEP review, we can still change the use of acq to trc. Would this then be ok for people that we make this change now?

nicholst commented 3 years ago

I think moving to trc is a good call... there isn't a perfect acq analogy, but if we were back in the days of retractable septa, you could imagine acq being used to tag 2D vs 3D acquistions. As another example, what if you took a single list mode dataset and played it out into sets of 5 min frames, and then did it again with, say, 7 min frames... wouldn't that be a good use for acq?

mnoergaard commented 3 years ago

I would argue that this latter case would imply a new reconstruction, as the acquisition of the data has not changed, but the reconstruction into frames has. Therefore, the data would need a new ´rec´ name (recon), such as ´rec-acdynXX´ (https://bids-specification.readthedocs.io/en/bep-009/04-modality-specific-files/09-positron-emission-tomography.html).

But I agree that ´acq´ could be used for 2D vs. 3D, even though there are only a few sites out there that still use 2D acquisitions.

tsalo commented 3 years ago

Thanks to everyone for responding. Apologies for the round trip on this one! I will close this and follow up in the PET BEP.