bids-standard / bids-2-devel

Discussions and suggestions of backwards incompatible changes to BIDS
https://bids.neuroimaging.io/
Creative Commons Attribution 4.0 International
11 stars 1 forks source link

Make it possible to specify folders layout to be other than sub-{label}/[ses-{label}/] #54

Open yarikoptic opened 1 year ago

yarikoptic commented 1 year ago

Origin: Originally summarized/presented in https://github.com/bids-standard/bids-specification/issues/751#issuecomment-820800800 (not duplicating here for now) while discussing a possible "stimuli BEP" and where it boiled down to having some stim-{label}/ folders structure either at top level or under stimuli/, which is currently no defining any structure to use there. Current state: many usecases collected (see e.g. below), design being formalized in

Other relevant issues in this bids-2-devel or elsewhere I found which would be partially or fully addressed with such enhancement

yarikoptic commented 8 months ago

In like of discussion on Atlases BEP I think we should provide some overall formalization behind BIDS files/structure, which could sound like

overall organizational principle which could describe "how BIDS file hierararchy is built", we might be able at some point to state something like

Such principle already lays down well for our sub-/ses- hierarchy and having participants.tsv for sub- and sessions.tsv for _ses-, for _desc we have descriptions.tsv, so overall "backward compatible" (but see #55 which breaks it on two aspects: no ent- prefix and no _ent- portion in the filename prefix).

arnodelorme commented 5 months ago

Is there an example of a use case where this would be relevant? @yarikoptic BIDS 2.0 is meant to be more user-friendly. Complexifying an already complex scheme will not make BIDS 2.0 more user-friendly.

Also, about the logic with prefixes, entities, simmetries between all entities, etc. While it makes a lot of sense to computer scientists, it is completely lost on the common mortal.

yarikoptic commented 5 months ago

Examples are linked in the original description. Added one more for #59 . Any lack of "symmetry" actually hurts mortals (e.g. classical "why is it sub-, but then participants.tsv?" although it is a separate issue #14 but most representative of consistency/symmetry here).

mateuszpawlik commented 3 months ago

I second @arnodelorme here. I'm dealing with BIDS datasets for several years now while building a repository. I can't understand the motivations and implementations of this issue. Do you expect people and tools to understand a flexible layout like the one explained here? In my opinion, this adds an unnecessary level of indirection. Suddenly, all the tools we're using will have to interpret some directory layout specification. And once flexibility is allowed, you can expect everyone to use it, possibly leading to a different layout for each dataset.

It's complicated enough to deal with optional sessions while implementing a tool. We decided internally, and users didn't object, to make sessions mandatory just not to deal with handling that.

The strength of BIDS is its specificity, fixed directory structure, and file naming convention. I wouldn't go away from that.

yarikoptic commented 2 weeks ago

@arnodelorme and @mateuszpawlik thank you very much for chiming in! I would be happy to explain more on my motivation beyond use cases I keep populating in the original description. But may be we could discuss them "interactively"? Are you planing to attend upcoming INCF in Austin, TX or SfN in Chicago, IL? If not -- we could zoom.

Quick summary answer to @mateuszpawlik : one of the original motivations is that BIDS already covers more than just 'neuroimaging' data (e.g. microscopy) and even more modalities would become supported as time goes. Not all of them have subject as the level of differentiation most appropriate at the highest level. Could be as large as a "study" or as little as a "slice" (see OP for references). Talking about people, when you come to a new BIDS dataset and see that on first level you have sample-1/ , sample-2/ and so on, you would immediately understand (without even looking anywhere) that it is about different samples (it is a standard BIDS entity). And I do acknowledge that for tools it would indeed require some development to support the specification, instead of hardcoding fixed assumption of the hierarchy. But I also hope that common libraries like schemabidstools and pybids could assist in making such transitions easier, while empowering those tools to support a much wider range of cases.

tgbugs commented 2 weeks ago

One example use case is that if bids 2 were to include the ability to specify layout and metadata location/binding rules at a meta level, then it would be possible to express those rules for other standards (e.g. SDS). This would allow formats that diverged from bids 1 due to its limitations to reconverge on bids 2.

yarikoptic commented 2 weeks ago

Thank you @tgbugs for the feedback/support. Please :+1: this issue ;) Do you think you could compile a list of possible steps to converge SDS to BIDS, e.g. like I did for DANDI ?

tgbugs commented 1 week ago

I will take shot at a list of possible steps though will likely only get to it after Neuroinformatics and SfN.