bids-standard / bids-2-devel

Discussions and suggestions of backwards incompatible changes to BIDS
https://bids.neuroimaging.io/
Creative Commons Attribution 4.0 International
10 stars 1 forks source link

desc_id -> description_id and have values with desc- prefix #79

Open yarikoptic opened 1 month ago

yarikoptic commented 1 month ago

came up in the course of

_ids which are named for 3 out of 4 {entitylongname}_id (and value is {entityshortname}-{value} )

❯ grep '_id:$' objects/columns.yaml
desc_id:
participant_id:
sample_id:
session_id:

but I guess could be generalized for any entity (context: #54 ).

I think we should harmonize desc_id -> description_id and ensure we have value to be desc-{label} not just {label} as it is now in https://github.com/bids-standard/bids-specification/blob/master/src/derivatives/common-data-types.md?plain=1#L331 .

ATTN @bids-standard/bep016 folks (no team yet, sorry, hence @CPernet @tsalo as added/touched relevant stuff)

TODOs

effigies commented 1 month ago

@bids-standard/derivatives-mri-dwi Would probably be the BEP16 team.

Lestropie commented 1 month ago

Not sure if BEP016 is the right ping here; not doing anything in particular with _desc- there.