search

bids-standard / bids-bep016

BEP016: diffusion derivatives
Creative Commons Attribution 4.0 International
6 stars 7 forks source link

Move spherical harmonic basis keyvalue? #76

Closed Lestropie closed 6 months ago

Lestropie commented 2 years ago

Currently the spherical harmonic basis used is specified in the model JSON file, rather than the ODF JSON file. With inheritance this makes sense only if all of the model derivatives are SH ODFs. Likely a better solution would be for the individual ODFs to have within their sidecar files the SH convention used. That would prevent that information from being inherited by files to which it is not applicable, and would mean that any ODF image - metadata pair can be reasonably interpreted without necessitating reference back to the model JSON.

Lestropie commented 6 months ago

Intrinsically addressed by #92, as there is no model-wise JSON file, and "OrientationEncoding" is defined individually for each data file.