search

bids-standard / bids-examples

A set of BIDS compatible datasets with empty raw data files that can be used for writing lightweight software tests.
http://bids-standard.github.io/bids-examples/
168 stars 134 forks source link

MTS example do not follow current specs #459

Open bpinsard opened 1 month ago

bpinsard commented 1 month ago

In https://osf.io/k4bs5/ ds-mtsat uses outdated/pre-BEPS _acq-<MTOn|MTOff|T1w> rather thank _flip-<index>_mt-<on|off> which can confuse willing BIDSonauts. ;)

Remi-Gau commented 1 month ago

So in general we do allow some divergence between examples and the data that were used to generate them. But indeed this can be confusing...

@agahkarakuzu would you be OK if we moved those examples to openneuro?

This actually may be a good policy for examples in general because would help make sure that the datasets are at least kept valid (and easier to update)

bpinsard commented 1 month ago

Another thing I noticed in the examples are the very scarce metadata. If the dicoms still exists, it would be great to have all the metadata that dcm2niix now produces by default in the sidecar. I am mainly thinking about pulse sequences info and other MR related options.

bpinsard commented 1 month ago

Also regarding continuous BIDS-compliance testing, if the dataset is datalad with a fork hosted on github for the git part (full dataset can be on openneuro), we can set up github actions to run the bids-validator when changes are made and also scheduling it (~1/month) with latest bids-validator. for example: https://github.com/courtois-neuromod/anat/blob/main/.github/workflows/bids-validator.yml