search

bids-standard / bids-specification

Brain Imaging Data Structure (BIDS) Specification
https://bids-specification.readthedocs.io/
Creative Commons Attribution 4.0 International
275 stars 157 forks source link

[BUG] Different conventions used for TotalReadoutTime #1351

Closed nbeliy closed 1 month ago

nbeliy commented 1 year ago

Describe your problem in detail.

In MRI section TotalReadoutTime is defined using FSL convention: EffectiveEchoSpacing * (ReconMatrixPE - 1), this is confirmed in Glossary.

In qMRI appendix is defined using SPM convention: EffectiveEchoSpacing * PEReconMatrix.

Describe what you expected.

Can you please uniformise the definitions?

No need to tell the usage of different conventions depending on context is confusing and error prone.

BIDS specification section

https://bids-specification.readthedocs.io/en/stable/glossary.html#objects.metadata.TotalReadoutTime https://bids-specification.readthedocs.io/en/stable/appendices/qmri.html#tb1epi-specific-notes

Remi-Gau commented 1 year ago

@agahkarakuzu we may need your help on this.

sappelhoff commented 1 year ago

Also tagging @Gilles86

Gilles86 commented 1 year ago

Sure. Let's align the two to the one in the MRI section? How do we best go about that?

sappelhoff commented 1 year ago

Given that the MRI section is older we could correct the qMRI appendix to follow the MRI section and consider it a "bugfix". Then we'd potentially have to adjust the BIDS-validator and BIDS schema somewhere.

effigies commented 1 month ago

@nbeliy @Gilles86 Would you mind having a look at #1912?

nbeliy commented 1 month ago

Looks good for me