bids-standard / bids-specification

Brain Imaging Data Structure (BIDS) Specification
https://bids-specification.readthedocs.io/
Creative Commons Attribution 4.0 International
276 stars 160 forks source link

Entities applicable to derivatives only #1528

Open Lestropie opened 1 year ago

Lestropie commented 1 year ago

In stalking the Copenhagen BIDS Derivatives meeting, I passed comment on the fact that as the scope of BIDS Derivatives increases, there will be an increasing number of entities that are not considered valid for raw BIDS datasets, and are valid only for BIDS Derivative datasets, and that a clear distinction regarding this will need to be established in the specification.

@Remi-Gau suggested that there already exists some level of distinction. I searched and found that for some entities, eg. atlas, the string "This entity is only applicable to derivative data" appears in the Description.

What I propose is that in time a stronger distinction will be necessary.

Some thoughts (certainly not an exhaustive list, happy to seed a more general discussion):

Remi-Gau commented 1 year ago

I was actually more referring to the fact that some entities only appear in the schema for derivatives files, but never for raw files.

See for example: https://github.com/bids-standard/bids-specification/blob/f2cea0f43444b55c9885a9717b25272b27790959/src/schema/rules/files/deriv/imaging.yaml#L2-L9

I agree that the 2 additions to the appendices would be most welcome.

I suspect that whether an entity is raw or derivatives should be probably be done by modifying the schema in the following file:

The sentence "This entity is only applicable to derivative data" could then be removed from the definition of entities and we would let the rendering macro add it where needed.

@effigies @tsalo any thoughts?

oesteban commented 1 year ago

I agree the schema seems the most unambiguous place for this distinction