bids-standard / bids-specification

Brain Imaging Data Structure (BIDS) Specification
https://bids-specification.readthedocs.io/
Creative Commons Attribution 4.0 International
274 stars 157 forks source link

[SCHEMATOOLS] Implement inheritance for all TSV/JSON files #1671

Closed effigies closed 7 months ago

effigies commented 9 months ago

The previous implementation assumed that, if a file rule only contained TSV or JSON files, then at least one of these was not inheritable. This seems to contradict the inheritance principle, unless the files cease to be "metadata" files, as well as fails to validate actual files in examples, such as channels.tsv and events.tsv.

If the rule needs to become more complex, the schema will need a way to indicate whether a rule addresses data or metadata files.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (51f1d1f) 87.97% compared to head (7d8844e) 87.93%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1671 +/- ## ========================================== - Coverage 87.97% 87.93% -0.05% ========================================== Files 16 16 Lines 1356 1351 -5 ========================================== - Hits 1193 1188 -5 Misses 163 163 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.