search

bids-standard / bids-specification

Brain Imaging Data Structure (BIDS) Specification
https://bids-specification.readthedocs.io/
Creative Commons Attribution 4.0 International
274 stars 157 forks source link

SCHEMA: Add file rule for phenotype tables #1672

Closed effigies closed 4 months ago

effigies commented 9 months ago

This PR slightly amends how stem rules work, by making the stem a glob pattern and allowing it to coexist with datatype. This hacks 'phenotype' into the datatype structure; in the absence of entities, it works correctly for now.

I don't know that this is a long-term solution, but it seems good enough for now with minimal changes required to the schematools or the JS schema validator.

This is intended to be compatible with, but not actually dependent on #1693.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.04%. Comparing base (0950f6d) to head (8454ebd). Report is 115 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1672 +/- ## ========================================== + Coverage 87.92% 88.04% +0.11% ========================================== Files 16 16 Lines 1375 1380 +5 ========================================== + Hits 1209 1215 +6 + Misses 166 165 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

effigies commented 8 months ago

Closed in favor of #1693.

effigies commented 7 months ago

@rwblair @tsalo Let me know what you think.