search

bids-standard / bids-specification

Brain Imaging Data Structure (BIDS) Specification
https://bids-specification.readthedocs.io/
Creative Commons Attribution 4.0 International
274 stars 157 forks source link

[MISC] Restructure MEG empty room example texts #1677

Closed guiomar closed 8 months ago

guiomar commented 9 months ago

Edit: Removed boilerplate.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (master@a73a310). Click here to learn what that means.

:exclamation: Current head 0f3d0a4 differs from pull request most recent head 441fa10. Consider uploading reports for the commit 441fa10 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1677 +/- ## ========================================= Coverage ? 87.97% ========================================= Files ? 16 Lines ? 1356 Branches ? 0 ========================================= Hits ? 1193 Misses ? 163 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

effigies commented 8 months ago

This is fine. I'm not 100% in favor of including spec language likes SHOULDs and MUSTs in examples, but it doesn't change the meaning of the spec, so if this helps people find the information they need, fine.