search

bids-standard / bids-specification

Brain Imaging Data Structure (BIDS) Specification
https://bids-specification.readthedocs.io/
Creative Commons Attribution 4.0 International
267 stars 154 forks source link

[ENH] Add support for HiP-CT #1686

Closed balbasty closed 4 months ago

balbasty commented 5 months ago

Resolves: #1646

This PR introduces a new hipCT microscopy suffix.

It does not make any changes to the required or optional metadata. To me, HiP-CT is not a quantitative modality, so I do not see any parameters that would be required for downstream analysis. Please give feedback if you feel that this is not correct and that hip-ct-specific metadata should be added.

I am leaving it as a draft PR for now.

cc @satra @ucbpclw

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.93%. Comparing base (327bece) to head (cfe7ac1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1686 +/- ## ======================================= Coverage 87.93% 87.93% ======================================= Files 16 16 Lines 1351 1351 ======================================= Hits 1188 1188 Misses 163 163 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

effigies commented 5 months ago

This seems fine to me, and there were no objections on the discussion #1646.

@jcohenadad Do you see any problems with this?

jcohenadad commented 5 months ago

@jcohenadad Do you see any problems with this?

on the contrary, this is a great addition!

balbasty commented 5 months ago

Thanks! I removed the draft mode

effigies commented 4 months ago

Note that by the rules we do need a second approving review by a community member. (It does not need to be a maintainer.)