search

bids-standard / bids-specification

Brain Imaging Data Structure (BIDS) Specification
https://bids-specification.readthedocs.io/
Creative Commons Attribution 4.0 International
274 stars 157 forks source link

[BUG] Insufficient changes to extend `task-<label>` to anatomical data #1692

Open oesteban opened 8 months ago

oesteban commented 8 months ago

Describe your problem in detail.

In #1185, the task-<label> entity was introduced, but at the same time, it introduced two problems:

  1. The PR did not include any language about events files and metadata, so today task-<label> only adds one entity to the anatomical data but that task cannot be fully specified (I guess there could be a way of doing so with beh/, but that was already the case before #1185 was merged). It would be necessary to add the necessary language to the spec. I think the task-<label> entity should be used ONLY for disambiguation (i.e., if, e.g., during the T1w imaging more than one task or no-task happened across the dataset).
  2. What happens with dwi, for instance. Is it not anatomical? #1185 should be cast up to cover, at least, all MRI datatypes, and denominated OPTIONAL for all the datatypes (except for functional and others where it was already MANDATORY).

Describe what you expected.

That #1185 was more generally applied and fully implemented (i.e., events files)

BIDS specification section

https://bids-specification.readthedocs.io/en/stable/modality-specific-files/magnetic-resonance-imaging-data.html#task-metadata-for-anatomical-scans

oesteban commented 8 months ago

(where I say events, it should also say stim)

Remi-Gau commented 8 months ago

Adding those would be ok with me.