bids-standard / bids-specification

Brain Imaging Data Structure (BIDS) Specification
https://bids-specification.readthedocs.io/
Creative Commons Attribution 4.0 International
274 stars 157 forks source link

Fix up examples in src/schema/README.md to not use outdated schema paths #1698

Closed yarikoptic closed 6 months ago

yarikoptic commented 8 months ago

I also developed a script to catch those no longer valid paths used. I think it is worth adding it on CI

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.93%. Comparing base (327bece) to head (1c0edcd).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1698 +/- ## ======================================= Coverage 87.93% 87.93% ======================================= Files 16 16 Lines 1351 1351 ======================================= Hits 1188 1188 Misses 163 163 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yarikoptic commented 7 months ago

I found where schema.org is produced -- in RTD, but there in env there is no jq so RTD succeeds but log says

tools/no-bad-schema-paths.sh: line 19: jq: command not found
meta.context.context: not reachable
tools/no-bad-schema-paths.sh: line 19: jq: command not found
objects.columns: not reachable
tools/no-bad-schema-paths.sh: line 19: jq: command not found
objects.common_principles: not reachable
tools/no-bad-schema-paths.sh: line 19: jq: command not found

moreover -- RTD succeeds! so that would not be appropriate place. we need to do it in another CI

yarikoptic commented 7 months ago

yeay -- it worked, removing TEMP commit:

image